Re: [PATCH v2 3/7] firmware: dmi: Read additional information when decoding DMI table

Yazen Ghannam
2025-12-18T15:43:40Z

On Wed, Dec 17, 2025 at 03:23:10PM -0600, Mario Limonciello wrote:
> On 12/17/25 3:21 PM, Yazen Ghannam wrote:
> > On Wed, Dec 17, 2025 at 03:09:33PM -0600, Mario Limonciello wrote:
> > > On 12/17/25 3:03 PM, Yazen Ghannam wrote:
> > > > On Tue, Dec 16, 2025 at 06:33:50AM -0600, Mario Limonciello (AMD) wrote:
> > > > > Type 40 entries (Additional information) are summarized in section
> > > > > 7.41 as part of the SMBIOS specification. Save these entries when
> > > > > decoding the DMI tables.
> > > > >
> > > >
> > > > Why can't an interested user just use dmidecode?
> > > >
> > > > Thanks,
> > > > Yazen
> > >
> > > They could. The reason for doing it in this series is the same reason for
> > > the one that we did the S5 bit.
> > >
> > > It shows up in the logs, you can tie regressions to the AGESA version at
> > > specifically at the time of the failure if they've done BIOS updates since
> > > then.
> >
> > Yes, right. Sorry, I mixed this up with the debugfs patch.
> >
> > We need to save it here so the init code can find it.
> >
> > But why do we need a debugfs entry for it?
>
> Ah. That one I don't feel strongly about.
>
> I used it when I was getting the series working and it felt like a waste to
> toss.

Oh okay. Yeah, maybe "don't feel strongly about it" is a good reason to
drop it. Just trying to think like a more frugal reviewer. :)

Thanks,
Yazen