From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C4ADF23EA82; Mon, 3 Nov 2025 07:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762156099; cv=none; b=WmUc/fgamHvDxeq/eGwJc2LWH5cACkyUlcFdUsEK7A/HqvnREK7v1aNeZ0zuvyszycLRKj4Hg6+vvOjBCWV8c5hoSQtlL/vxFNJ/X/kkQZPRxaebZgPWfLxlhxFLqwl4hrbP5XrbFNXdwF3wnonWJ32cDm4/+QqEL36Qv1eZJNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762156099; c=relaxed/simple; bh=sAetg5wQxTXN/XrKczQkuQwkA+poWoNsI04n+QS6IXc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HCp5aXrc6kdeUh0RTlp49wqe3pNshniUNc8RfvtCUKYo9/gfR5qSA3+9od0HdZmO2TfBFM9h8fUEmVRUtveyMUOElsSi4fuHn+SUYKajEFrP2PG0sQQP5gzENj9ZfbWBOd3D2C7HtTwkG+4p5xqDlgyV6VAD0nl9rdSXMPhlE6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 180A228FA; Sun, 2 Nov 2025 23:48:09 -0800 (PST) Received: from [10.164.146.19] (J09HK2D2RT.blr.arm.com [10.164.146.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DB9DC3F63F; Sun, 2 Nov 2025 23:48:13 -0800 (PST) Message-ID: <7d4d0d6a-390d-48d6-ba2a-7adfac2e30ca@arm.com> Date: Mon, 3 Nov 2025 13:18:11 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64/pageattr: Propagate return value from __change_memory_common To: Dev Jain , catalin.marinas@arm.com, will@kernel.org Cc: ryan.roberts@arm.com, rppt@kernel.org, shijie@os.amperecomputing.com, yang@os.amperecomputing.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20251103061306.82034-1-dev.jain@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20251103061306.82034-1-dev.jain@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/11/25 11:43 AM, Dev Jain wrote: > Post a166563e7ec3 ("arm64: mm: support large block mapping when rodata=full"), > __change_memory_common has a real chance of failing due to split failure. > Before that commit, this line was introduced in c55191e96caa, still having A small nit: Commit description needs to follow after the SHA ID ^^^^^^^^^^ > a chance of failing if it needs to allocate pagetable memory in > apply_to_page_range, although that has never been observed to be true. > In general, we should always propagate the return value to the caller. > > Cc: stable@vger.kernel.org > Fixes: c55191e96caa ("arm64: mm: apply r/o permissions of VM areas to its linear alias as well") Does is really need a Fixes: ? There is no problem which is being fixed. > Signed-off-by: Dev Jain > --- > Based on Linux 6.18-rc4. > > arch/arm64/mm/pageattr.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c > index 5135f2d66958..b4ea86cd3a71 100644 > --- a/arch/arm64/mm/pageattr.c > +++ b/arch/arm64/mm/pageattr.c > @@ -148,6 +148,7 @@ static int change_memory_common(unsigned long addr, int numpages, > unsigned long size = PAGE_SIZE * numpages; > unsigned long end = start + size; > struct vm_struct *area; > + int ret; > int i; > > if (!PAGE_ALIGNED(addr)) { > @@ -185,8 +186,10 @@ static int change_memory_common(unsigned long addr, int numpages, > if (rodata_full && (pgprot_val(set_mask) == PTE_RDONLY || > pgprot_val(clear_mask) == PTE_RDONLY)) { > for (i = 0; i < area->nr_pages; i++) { > - __change_memory_common((u64)page_address(area->pages[i]), > + ret = __change_memory_common((u64)page_address(area->pages[i]), > PAGE_SIZE, set_mask, clear_mask); > + if (ret) > + return ret; > } > } Although the change does make sense.