From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12CF23128D8 for ; Mon, 5 Jan 2026 15:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767626596; cv=none; b=pQfdLiSKex4l1kxKJjeuW1jeueWJQHw2REPvAi3KTuHL2Xk7URSQlCryQ7W0+hOANf/A4UIieeBQ9AjE1Ldhng6IFZSvjPP0GuEUCe0RsvBnPO4nAi2h1/WjSkzYp6CoHgB7PwODP4heD6hRfmG/MDn7zzV/HBJrtrpOzzJsmJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767626596; c=relaxed/simple; bh=rfmM0oHlriEWS2KwQfEnAdbuaeGQ7LHz+vEupFI4Xa8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UlrIoWTOjPjUM/dVb4Vw+1eRGBaECdF8k+bNDC3XnUpyRnpVRx6kRnIbxNOxhfjHp9x4C2zzboTZVPfUh6cj4e50H4b/sND1DLlLykmT02f8OMW1wYHpu/wwuMuQAAikD03tydkWJDKq8b5AvlFQ48oGYV5uBEpHYCE7XEBozeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e9CHjaOV; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e9CHjaOV" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7c750b10e14so22532a34.2 for ; Mon, 05 Jan 2026 07:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767626592; x=1768231392; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XuBj4V4tanBoMRJVAMOCXf92ggYa0XV5YWXJxw2KNiU=; b=e9CHjaOVMPT3x70LJi28DKO7dAYLIl13zrImoj8uElp74aZTVMqZfAqzRMdo+7JO3+ FBXg41SF6whMPyljzpHeHmRx8GFf783RclSbEL7sg/UV9XXv9BM9SsRLCFOwAZNlPIOM M1ouKKwtaz3rnMqqxVSv6ctYjnWEChq67HEN3J6KLbF43oS7sO+KUSWwO/kw4YJLgkdC KeYO9OX4ZnGkqbZTXzqngR9TULQ911d4C87DqtU7034PNraDeR9zn45Tkr5p51ao9d62 hCK98/8GnjErA/j7E+viRZK915DTm+mzV/FhIWQmYZgBV0X95ZO33QMDFGRvbgIt9aN4 RG2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767626592; x=1768231392; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XuBj4V4tanBoMRJVAMOCXf92ggYa0XV5YWXJxw2KNiU=; b=SUsshMx2uXxYKSvhSElg1gIECgXBp6BcXOpLrlG7LeGy9qS5GZFJI8zFEsXFZYif/Q CF7jBB807Pquhgy1Dvt3D6HLcu7j/tudhpczP3uFFxiWSTOCBTrjcxM26c8/rxKzCk8m sUgbRkWJ3T8BqDn0lGuTLBS0EF70CwcyJ5fkwcQAo09e4l87sldom+W+HrPQTfggBN2O jnIm2OwWv2NuZWNYhLS4tkgxTU+QzjMRIpkPqpqj6srIUmYyKZxAVIEIQiZzU1NOepLF hcVtkOFGBzO2hrlFFZzm0DwqMXwA20B/V1EqeGpX8W7EwznzmG18OLT5gVDEwgMCaBDG 7hAA== X-Forwarded-Encrypted: i=1; AJvYcCX2q3BOPuf+o1XvF3fqLRRbqk3RpmrHUKdE/UToy/jChjrTNxSMPx3UcQVRDlSkRNqTQN1gArKQ1jazzng=@vger.kernel.org X-Gm-Message-State: AOJu0YzQV+mIMccRZTZIUciqYv+YXaYYNuUvQIbRef7pGPKXkKTI25La x17g32DWkQuz9kbI50sEb7kaSJ6IXX228fUtWPUQ3jeulDwjY68LlMmA X-Gm-Gg: AY/fxX7Xh8nZnM54zT+2kb2vvQmXjLfkfjTeJMIp0NPt0uT6YWNOE0Pmkl+lLCrBFZ8 srC4s1Yg7R1rvK+FZy7NTIpupxwBm8cFUpMcJppeuzYy8SszXTw2wlvWY8fm0aPNRhQoOUjwzjV n6X3ds20Gz2zRX1fX01cFQrVxoQ9nI7oG0OV2SpkACJxYvvdDPJXyhmLKUcdvs6NjB2Vv6BsIIp 6MlTGUAjIHSXvEaroXT9bOmW6IDOZsmiIO+yXicdLh6IFPMO1PWnKdK6JEfAYgVzcQtFrSCojFV WJtgxtH3djvpoj96sQfiVUlKvBgcK1an+6IZeo+Tqma0R5YDjJ68Me4Jw3kgR761YZrybuCxq2R wc6YtDsYamtfYqqMU6Zvn5t2uu0w47kNq4C9Ra0G1eq149s3aWwSyOC9lo3rPfKRmkGHjzZBcyv scq7+3tGgAsskkzabBZcpREGgivIqCFtdi2/5p58ONID1LA6Rsriv3U0jIoS/olVeEaJ6uVBPVr 5R1zhXlfBBswtykO1c0JTIPxKaaxl11Mw== X-Google-Smtp-Source: AGHT+IHC0T34oUBbEa5lhbSB8wM+95jVMHVncLiRRnQsCbvUgDbHbtOBPFwou8Zv2vRl7ztJFMdTPg== X-Received: by 2002:a05:6830:43a3:b0:756:a322:311 with SMTP id 46e09a7af769-7cc669001a2mr37442477a34.10.1767626591751; Mon, 05 Jan 2026 07:23:11 -0800 (PST) Received: from [192.168.7.203] (c-98-57-15-22.hsd1.tx.comcast.net. [98.57.15.22]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ce45ffb5fesm27703a34.25.2026.01.05.07.23.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jan 2026 07:23:11 -0800 (PST) Message-ID: <7d5be110-c605-4a02-8121-1c4cb2571bb8@gmail.com> Date: Mon, 5 Jan 2026 09:23:10 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/9] remoteproc: qcom_q6v5_wcss: support m3 firmware To: Konrad Dybcio , andersson@kernel.org Cc: mathieu.poirier@linaro.org, krzk+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251219043425.888585-1-mr.nuke.me@gmail.com> <20251219043425.888585-7-mr.nuke.me@gmail.com> <5b9cd24e-7eae-4cbb-b013-6ef135902ae7@oss.qualcomm.com> <5116928.iIbC2pHGDl@nukework.gtech> <4e21205e-0b09-496e-9d6f-9fe2c327c13a@oss.qualcomm.com> Content-Language: en-US From: mr.nuke.me@gmail.com In-Reply-To: <4e21205e-0b09-496e-9d6f-9fe2c327c13a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/29/25 6:37 AM, Konrad Dybcio wrote: > On 12/23/25 9:35 PM, Alex G. wrote: >> On Friday, December 19, 2025 7:29:07 AM CST Konrad Dybcio wrote: >>> On 12/19/25 5:34 AM, Alexandru Gagniuc wrote: >>>> IPQ8074, IPQ6018, and IPQ9574 support an m3 firmware image in addtion >>>> to the q6 firmware. The firmware releases from qcom provide both q6 >>>> and m3 firmware for these SoCs. Support loading the m3 firmware image. >>>> >>>> Signed-off-by: Alexandru Gagniuc >>>> --- > > [...] > >>>> +static int q6v5_wcss_load_aux(struct q6v5_wcss *wcss, const char >>>> *fw_name) >>>> +{ >>>> + const struct firmware *extra_fw; >>>> + int ret; >>>> + >>>> + dev_info(wcss->dev, "loading additional firmware image %s\n", >> fw_name); > > Your email client is messing up the reply context - if it happens to > be Thunderbird, set: > > mailnews.wraplength = 0 > mailnews.send_plaintext_flowed = false > > in the config Oops. >>> >>> I don't think this log line is useful beyond development >> >> Remoteproc driver prints the main (q6) fimrware name, so I thought it would be >> prudent to print the names of any additional firmwares: >> >> remoteproc remoteproc0: Booting fw image IPQ9574/q6_fw.mdt, size 8140 >> >>>> + >>>> + ret = request_firmware(&extra_fw, fw_name, wcss->dev); >>>> + if (ret) >>>> + return 0; >>> >>> return ret, perhaps? Unless you want to say that "it's fine if the M3 image >>> is missing, particularly not to impose any new requirements on existing >>> setups". But you haven't spelt that out explicitly. >> >> I intended to not abort when aux firmware is missing. Maybe the better way to >> handle this is to check for "-ENOENT" in the caller instead of return 0 here. >> >>> You also haven't provided an explanation as to why the firmware should be >>> loaded. Is it necessary for some functionality? Is it that case on the >>> newly-supported IPQ9574? >> >> I don't have a good answer. I reasoned that since the qcom provides it [1], >> the M3 firmware would need to be loaded. I haven't done much testing without >> it. > > Well, could you please try? > > IIRC it was strictly necessary for ATH1xk-on-PCIe so I'm assuming it's going > to be a necessity here as well I tried this without the M3 firmware, and I don't see a measurable difference in normal operation. I only tested AP mode briefly. How can I know for sure if the M3 firmware is needed or not? Alex