From: graff yang <graff.yang@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: tj@kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] mm/nommu.c:Dynamic alloc/free percpu area for nommu
Date: Tue, 23 Mar 2010 10:33:49 +0800 [thread overview]
Message-ID: <7d86d44a1003221933x50378b37oe9556e1f169ff15a@mail.gmail.com> (raw)
In-Reply-To: <28495.1269258639@redhat.com>
On Mon, Mar 22, 2010 at 7:50 PM, David Howells <dhowells@redhat.com> wrote:
> <graff.yang@gmail.com> wrote:
>
>> - return virt_to_page(addr);
>> + return (struct page *)
>> + (virt_to_page(addr)->index) ? : virt_to_page(addr);
>
> Can the extra conditional operator be made subject to CONFIG_SMP?
OK.
Tejun is looking into the up layer percpu code. So I expecting there
is better way
to hook nommu in.
>
>> - return page_to_pfn(virt_to_page(addr));
>> + return page_to_pfn((struct page *)
>> + (virt_to_page(addr)->index) ? : virt_to_page(addr));
>
> Ditto.
>
>> +#ifdef CONFIG_SMP
>> ...
>> +#endif
>
> Can this be put into a separate file? There's rather a lot in mm/nommu.c
> these days.
>
> David
>
--
-Graff
prev parent reply other threads:[~2010-03-23 2:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 9:02 [PATCH] mm/nommu.c:Dynamic alloc/free percpu area for nommu graff.yang
2010-03-20 4:06 ` Tejun Heo
2010-03-22 2:33 ` graff yang
2010-04-01 10:20 ` Tejun Heo
2010-04-06 9:28 ` Sonic Zhang
2010-04-08 2:43 ` Tejun Heo
2010-04-08 9:40 ` Sonic Zhang
2010-04-08 23:33 ` Tejun Heo
2010-03-22 4:14 ` [Uclinux-dist-devel] [PATCH] mm/nommu.c:Dynamic alloc/freepercpu " Zhang, Sonic
2010-03-22 11:50 ` [PATCH] mm/nommu.c:Dynamic alloc/free percpu " David Howells
2010-03-23 2:33 ` graff yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d86d44a1003221933x50378b37oe9556e1f169ff15a@mail.gmail.com \
--to=graff.yang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).