From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0344C433EF for ; Sat, 12 Mar 2022 15:16:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231797AbiCLPRX (ORCPT ); Sat, 12 Mar 2022 10:17:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231745AbiCLPRU (ORCPT ); Sat, 12 Mar 2022 10:17:20 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F51E1B6E15; Sat, 12 Mar 2022 07:16:14 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id o6so15945048ljp.3; Sat, 12 Mar 2022 07:16:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=yP2kewe3ti9ZfOopOVa7K12sPi5NnAgBl2PzcRBkWxE=; b=DWV+Ze/xxejqT2xuEHPDwP7tMXEou8ChjnbYU9d1tNyzMZ+aeyZ5Eipp7rVQ+LfV6+ FGe6sze7Te+y03eLyZ9iTRz7Z7aKNT96YQfhnf5YiyADQfaMoICoPra4LuNFZaCfeV62 XOkto9pkMGGB075KVJlJcoF41LQvl8cnBFxo8nhgaSGaAPUUw9pY3U5ou+zTMMe8GmUV M6ViOlgC52qZpszdGsT5vOVADEABD2c86+XTKhT6XRN5/0cBvPGjMkMlRDsU7cJmzLqK e1FxnLLcWkZgTQ/uw79IQdPFN93ea+O9k7NiBx3ly8R9hAJsbryKPWBCP60CG0ggXOP4 FosA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=yP2kewe3ti9ZfOopOVa7K12sPi5NnAgBl2PzcRBkWxE=; b=GDONWJIZd99v+Dn7RhuLbaMxiToIeJcttYKWQ6mCA5z1TkVb4phacU6TGWfp9yXx/4 sDlOto4woWyodFpjKgmUqIR26sr74/xnGn6hKWU1ywEyPO8OhCyyPZXVE8QBqhjsH2w+ nq003qU1iYtv7uWMifOSryBLhMe0L8Fai+w7s8HueufmABoKmlKnQGKJWYVXuIDP9pud mBu8rkEgI/HT+RH0dMckSOYi5kxeOfbloem2Kyc3BOS8itf1r2Yq4XSkr4GDUrW4e/xh i5bkah72COQOK40E2CFqQSbTBilJFkBIh+IUcLk5QvU3ZCB861lBPRpzA5evd9MsF0/a SPMQ== X-Gm-Message-State: AOAM530XHXREXtG7toEGs/xbsaOC+WJgMqleaWJn7bIgf0nKJpQASOfh PDy806NEKahgixq4sRQR5Co= X-Google-Smtp-Source: ABdhPJxWFf7aRx4X94FoJ/xI/3+bHDfLbdTua46QbroQpRlZlIlc9vUOewmmfV/XlVccLiPGLtoKwg== X-Received: by 2002:a2e:7d18:0:b0:247:f205:96fa with SMTP id y24-20020a2e7d18000000b00247f20596famr9020348ljc.269.1647098170958; Sat, 12 Mar 2022 07:16:10 -0800 (PST) Received: from [192.168.1.11] ([94.103.229.107]) by smtp.gmail.com with ESMTPSA id k9-20020a192d09000000b004487dfc9d9csm668361lfj.260.2022.03.12.07.16.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Mar 2022 07:16:10 -0800 (PST) Message-ID: <7da316f4-aa65-896e-9020-2dfff2bbfc09@gmail.com> Date: Sat, 12 Mar 2022 18:16:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: Fw:Re: [PATCH] fs: nilfs2: fix memory leak in nilfs sysfs create device group Content-Language: en-US To: Ryusuke Konishi , Dongliang Mu Cc: Andrew Morton , linux-nilfs , LKML , Nanyong Sun , =?UTF-8?B?5oWV5Yas5Lqu?= References: <3192BC90-D082-472B-B310-6E09A14A77C6@hust.edu.cn> From: Pavel Skripkin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ryusuke, On 3/12/22 18:11, Ryusuke Konishi wrote: >> In case of nilfs_attach_log_writer() error code jumps to >> failed_checkpoint label and calls destroy_nilfs() which should call >> nilfs_sysfs_delete_device_group(). > > nilfs_sysfs_delete_device_group() is called in destroy_nilfs() > if nilfs->ns_flags has THE_NILFS_INIT flag -- nilfs_init() inline > function tests this flag. > > The flag is set after init_nilfs() succeeded at the beginning of > nilfs_fill_super() because the set_nilfs_init() inline in init_nilfs() sets it. > > So, nilfs_sysfs_delete_group() seems to be called in case of > the above failure. Am I missing something? > Yeah, that's what I mean :) I can't see how reported issue is possible with current code. Sorry for not being clear With regards, Pavel Skripkin