Re: [PATCH v4 2/4] dt-bindings: PCI: qcom: Document the Glymur PCIe Controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 11/10/2025 14:15, Abel Vesa wrote:
>>  
>>  properties:
>>    compatible:
>> -    const: qcom,pcie-x1e80100
>> +    oneOf:
>> +      - const: qcom,pcie-x1e80100
>> +      - items:
>> +          - enum:
>> +              - qcom,glymur-pcie
>> +          - const: qcom,pcie-x1e80100
>>  
> 
> The cnoc_sf_axi clock is not found on Glymur, at least according to this:
> 
> https://lore.kernel.org/all/20250925-v3_glymur_introduction-v1-19-24b601bbecc0@oss.qualcomm.com/
> 
> And dtbs_check reports the following:
> 
> arch/arm64/boot/dts/qcom/glymur-crd.dtb: pci@1b40000 (qcom,glymur-pcie): clock-names: ['aux', 'cfg', 'bus_master', 'bus_slave', 'slave_q2a', 'noc_aggr'] is too short
>         from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-x1e80100.yaml#
> 
> One more thing:
> 
> arch/arm64/boot/dts/qcom/glymur-crd.dtb: pci@1b40000 (qcom,glymur-pcie): max-link-speed: 5 is not one of [1, 2, 3, 4]
>         from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-x1e80100.yaml#
> 

So that's another Glymur patch which wasn't ever tested?

Best regards,
Krzysztof