From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: Gao Xiang <xiang@kernel.org>,
linux-erofs@lists.ozlabs.org, Chao Yu <chao@kernel.org>,
Yue Hu <huyue2@coolpad.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Gao Xiang <hsiangkao@linux.alibaba.com>
Subject: Re: [PATCH 1/2] erofs: get rid of debug_one_dentry()
Date: Mon, 16 Jan 2023 10:24:05 +0800 [thread overview]
Message-ID: <7db7240f-cf5a-7d0e-6da9-af69641ff18e@linux.alibaba.com> (raw)
In-Reply-To: <20230114125746.399253-1-xiang@kernel.org>
On 1/14/23 8:57 PM, Gao Xiang wrote:
> From: Gao Xiang <hsiangkao@linux.alibaba.com>
>
> Since erofsdump is available, no need to keep this debugging
> functionality at all.
>
> Also drop a useless comment since it's the VFS behavior.
>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
The code LGTM.
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
--
Thanks,
Jingbo
next prev parent reply other threads:[~2023-01-16 2:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 12:57 [PATCH 1/2] erofs: get rid of debug_one_dentry() Gao Xiang
2023-01-14 12:57 ` [PATCH 2/2] erofs: simplify iloc() Gao Xiang
2023-01-14 14:46 ` kernel test robot
2023-01-14 15:08 ` [PATCH v2 " Gao Xiang
2023-01-16 1:52 ` Yue Hu
2023-01-16 2:22 ` Jingbo Xu
2023-02-14 13:44 ` Chao Yu
2023-01-16 2:24 ` Jingbo Xu [this message]
2023-01-16 2:47 ` [PATCH 1/2] erofs: get rid of debug_one_dentry() Yue Hu
2023-02-14 13:40 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7db7240f-cf5a-7d0e-6da9-af69641ff18e@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox