From: Milo Kim <woogyom.kim@gmail.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Mark Brown <broonie@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer size
Date: Fri, 21 Oct 2016 22:39:52 +0900 [thread overview]
Message-ID: <7dbf6c9f-361b-9e31-8305-469ba4f274a8@gmail.com> (raw)
In-Reply-To: <20161020155641.b3erji5vrkk3wvia@lukather>
On 10/21/2016 12:56 AM, Maxime Ripard wrote:
>> -static inline void sun6i_spi_drain_fifo(struct sun6i_spi *sspi, int len)
>> > +static inline void sun6i_spi_drain_fifo(struct sun6i_spi *sspi)
>> > {
>> > + int len = sspi->fifo_depth;
>> > u32 reg, cnt;
>> > u8 byte;
> I'm not so sure about this one. This function was initially to drain
> any given number of bytes, which might be of interest at some point.
>
> Removing that argument also remove that ability... Any particular
> reason you want to change it?
I just wanted to remove duplicate variable but I agree with you. Let me
drop this in the next patch-set. Thanks for your comments.
Best regards,
Milo
prev parent reply other threads:[~2016-10-21 13:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 14:02 [PATCH 0/3] Support H3 SPI controller Milo Kim
2016-10-19 14:02 ` [PATCH 1/3] spi: sun6i: Add binding for Allwinner " Milo Kim
2016-10-20 15:45 ` Maxime Ripard
2016-11-03 15:42 ` Applied "spi: sun6i: Add binding for Allwinner H3 SPI controller" to the spi tree Mark Brown
2016-10-19 14:02 ` [PATCH 2/3] spi: sun6i: Support Allwinner H3 SPI controller Milo Kim
2016-10-20 15:50 ` Maxime Ripard
2016-10-20 15:53 ` Chen-Yu Tsai
2016-10-21 13:36 ` Milo Kim
2016-10-19 14:02 ` [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer size Milo Kim
2016-10-20 15:56 ` Maxime Ripard
2016-10-21 13:39 ` Milo Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dbf6c9f-361b-9e31-8305-469ba4f274a8@gmail.com \
--to=woogyom.kim@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox