From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDE66227E9B for ; Thu, 20 Mar 2025 22:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742508397; cv=none; b=LIHXZKNIpNAga2eVEx5Iy2apS0n8BKe+Vv3aJkp6smjNGYtIzvv2Vse0aYsHLfnLWv9pfNOqawizy+AvWP/jNQ7By/qA9rqvDnz/VCBK3M3JwL3VxBRmrb4r+85RVbFMDhg0BDAz0HU3IlKRdqQyxAhPq2C68n9x5v6tthFS2T8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742508397; c=relaxed/simple; bh=wVNswW8rL4OetwqeJVEiR14YDddt4iIFHENN5BwD65c=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=JNrl2oGgbaI18HLDxeUqwIyUdNGtjIzoffFiYga0aPD6HMz+URzuHa2faIeoY9C+rw/yP01BSaBlFTsNG6IuS+JD3WKlpkWkPldHBoMS3VqD+rsHCF2MviOruc+Ic0AkiYI/nc/1PfitN1Pb/uw7oCExLh5hIM7zTwdCln4GiYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VFEcz5p5; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VFEcz5p5" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43cfe574976so8133405e9.1 for ; Thu, 20 Mar 2025 15:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742508393; x=1743113193; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=S+DKgKKe0d2S0aLSGa2DZ5AxLYPiZ/5bN97M2PhD9xQ=; b=VFEcz5p5PxWd8KE8AHf+jggrtqzwlB6lwxj5zzG3vL5xcaCcDITZdhKZtDetK3//j3 eX9s+1QTYJp6MbncUPplXY7t4h2kmKo+AJQ2at43n7B6qUTr4v3rLpBGVc8ZvjrretAa ApziytqIYQR/gAmUS5c/DYYh3KQn7gFsHtFMb4gDiY4WgD9JD00OYMHSTiVbpz6OHXrs bQ8H1Rxc0EGieHZiXyNkN9pHjnQqApZBDTsvrdLW+aIlTIa1jrsaedhh7WBjVc7YMTOS tIhTLUwuNlZdoW3F7x8coZ5tRCjDUaMGqp3eWbshyLThFNAG7pInnaZBJKe/lkt0vWRK UP3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742508393; x=1743113193; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S+DKgKKe0d2S0aLSGa2DZ5AxLYPiZ/5bN97M2PhD9xQ=; b=LWLQ6UY73Oz6oqIMNTR/17ipPEN5hL3o71e7pPXfAHWJQS3cqx8Kj2ofH9VyALCYhF kD33B0zan+JjEgZM4bR2nUGMQMMtAtF6VwG3fzjL0BfxExvdaQIE6rrCsIuMQxQqCAwJ VXyyVw8IhNi4ast5FQDl3av/19NZXgr7Trj2OZO5o8FmRtGlJxk/92Xm7Xpkx5be0ipS SoRXNPM8ShB7Jorn5outhSpyNxXg9QP1+QkbzdtRxmUG9GQnKhRAmyi1FMdthhyz/fts XcKxs8poPPiLUIq44ajkvwirMamEtFR1TogwbrXZjRntXOcVFBfP+mpbIaXLFmYtswqx 4v2w== X-Forwarded-Encrypted: i=1; AJvYcCXkscbuDLsb8gilHaBd6FF1hwJnaq5vjiVaR3iwN3tczAwlUSQ/8NF9d5Q6ZEh9VWIJGwiNHYJrQkRBlXY=@vger.kernel.org X-Gm-Message-State: AOJu0YyLRuEPjixW7BuBej0Hb84QE6Pnu8TICm+mg/S1O2x26IBlL6LZ b5LRPBpQkJ7C9TPBeN0a/LJWNzFaLr1hL6M9lr6weYuU5zUT6qVC+wbfnbzSlGk= X-Gm-Gg: ASbGncsjL3X1dl208SsfaPvB0RhUTKi94D9ty7kI8YNYvp4ejUpC/79JaXYkENeUwpb lbX7Q7ZpJpza3v1T+r8JIDrr+WfYZMOUaIL56rH0zCMdTZ8AgzsxTfNZUZB5oEdeI4LEYx0FxPx qHN2pJNe+93eBhXfWSpDiGQ+NIPAxIj2EHISCW8nc/NChzIoWNpGKM9YCWmAYdSOY8io39ENDIG iPSU0IcaSalGmrx1lCnI40cSSEv7IR1Bhdmq8I0mMDrSUmk7t8To5bvLDYwZtkuuS42gy5ygDAZ /6da1NCVXk6gYPdJ6tMxvsD2E6ULOPMXiIl4UrZ4k3pM0c3F72goCvk5KaIV2mEOY255rR8NsNE NT9Mlpoo8VA== X-Google-Smtp-Source: AGHT+IF666w+fhi7xMb+8oGJRC8UIY8sQphK9beWqbHC+xtVyIDPE6027D6kLOQ0WtAFbDSaxhPr2Q== X-Received: by 2002:a05:600c:4584:b0:43b:cc42:c54f with SMTP id 5b1f17b1804b1-43d509f433amr7194745e9.14.1742508392863; Thu, 20 Mar 2025 15:06:32 -0700 (PDT) Received: from [192.168.0.34] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3997f9e64casm662410f8f.73.2025.03.20.15.06.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Mar 2025 15:06:32 -0700 (PDT) Message-ID: <7dc8700f-0d53-45f5-bfff-2bec71c7053e@linaro.org> Date: Thu, 20 Mar 2025 22:06:31 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/3] arm64: dts: qcom: x1e80100: add bus topology for PCIe domain 3 To: Wenbin Yao , andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, quic_qianyu@quicinc.com, sfr@canb.auug.org.au, linux-arm-kernel@lists.infradead.org References: <20250320055502.274849-1-quic_wenbyao@quicinc.com> <20250320055502.274849-3-quic_wenbyao@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250320055502.274849-3-quic_wenbyao@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/03/2025 05:55, Wenbin Yao wrote: > From: Qiang Yu > > Add pcie3port node to represent the PCIe bridge of PCIe3 so that PCI slot > voltage rails can be described under this node in the board's dts. > > Signed-off-by: Qiang Yu > Signed-off-by: Wenbin Yao > --- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > index 46b79fce9..32e8d400a 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > @@ -3287,6 +3287,16 @@ opp-128000000 { > opp-peak-kBps = <15753000 1>; > }; > }; > + pcie3port: pcie@0 { Missing newline, please check your dtb checks. > + device_type = "pci"; > + compatible = "pciclass,0604"; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + bus-range = <0x01 0xff>; > + > + #address-cells = <3>; > + #size-cells = <2>; > + ranges; > + }; > }; Why is pice3port the only port to be enabled ? What about the other ports ? > pcie3_phy: phy@1be0000 { > -- > 2.34.1 > > --- bod