From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Feng Chunguo <chunguo.feng@semidrive.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"fengchunguo@126.com" <fengchunguo@126.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jiri Slaby <jirislaby@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tty: serial: fixed uart irq maybe cause irq storm
Date: Tue, 2 Apr 2024 14:38:48 +0300 (EEST) [thread overview]
Message-ID: <7dd8f053-aaba-beaa-0f2f-118b0b1c2d85@linux.intel.com> (raw)
In-Reply-To: <727f9378143988cc621a116574fe5252a8f42301.f0b607c1.a18c.4c73.a561.fef5700437ab@feishu.cn>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Mon, 1 Apr 2024, Feng Chunguo wrote:
> Hi Greg KH，
>
> Sent this path again.
>
> the irq should not be turned off here, what happens if some data comes in while this
> function is running? Will it be lost?
> --> lost，not receive other irq.
>
> When the uart was switching the baud rate from one to other, this issue can be
> reproduced.
>> This feels wrong,
>> the irq should not be turned off here, what happens if some data comes in while this
>> function is running? Will it be lost? thanks, greg k-h
Changing rate always risks losing what's currently on wire due to timing
related corruption, I don't think there there's a way around that IRQ
being enabled or not.
--
i.
next prev parent reply other threads:[~2024-04-02 11:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 9:30 [PATCH] tty: serial: fixed uart irq maybe cause irq storm fengchunguo
2024-04-01 9:39 ` Greg KH
[not found] ` <727f9378143988cc621a116574fe5252a8f42301.f0b607c1.a18c.4c73.a561.fef5700437ab@feishu.cn>
2024-04-02 11:38 ` Ilpo Järvinen [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-01 10:19 fengchunguo
2024-04-01 10:32 ` Greg KH
2024-04-02 11:45 ` Ilpo Järvinen
2024-04-02 14:27 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dd8f053-aaba-beaa-0f2f-118b0b1c2d85@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chunguo.feng@semidrive.com \
--cc=fengchunguo@126.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox