From: Karolina Stolarek <karolina.stolarek@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Julia Lawall <julia.lawall@inria.fr>,
kenechukwu maduechesi <maduechesik@gmail.com>,
<outreachy@lists.linux.dev>, <shreeya.patel23498@gmail.com>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rts5208: Replace delay function.
Date: Wed, 18 Oct 2023 09:52:36 +0200 [thread overview]
Message-ID: <7dde176b-1059-e9a4-a023-0243cce61d01@intel.com> (raw)
In-Reply-To: <2023101853-axis-stylist-f1b9@gregkh>
On 18.10.2023 09:45, Greg Kroah-Hartman wrote:
> On Wed, Oct 18, 2023 at 09:32:46AM +0200, Karolina Stolarek wrote:
>> On 18.10.2023 09:03, Julia Lawall wrote:
>>>
>>>
>>> On Tue, 17 Oct 2023, kenechukwu maduechesi wrote:
>>>
>>>> Replace udelay() with usleep_range() for more precise delay handling.
>>>>
>>>> Reported by checkpatch:
>>>>
>>>> CHECK: usleep_range is preferred over udelay
>>>
>>> This message is typically not a good candidate for outreachy patches,
>>> because you need access to the device to be sure that any change is
>>> correct.
>>
>> Could we add a paragraph on how to pick good checkpatch.pl error to fix to
>> the Outreachyfirstpatch docs? This could go to "Find a driver to clean up"
>> section, for example.
>
> The ability to find a "good" error changes over time, so this might be
> hard to do.
I agree, but we can all agree that experimenting with udelay during
Outreachy is not a good idea, and people should know about it
All the best,
Karolina
>
> good luck!
>
> greg k-h
next prev parent reply other threads:[~2023-10-18 7:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 1:03 [PATCH] staging: rts5208: Replace delay function kenechukwu maduechesi
2023-10-18 3:38 ` Andi Shyti
2023-10-18 7:03 ` Julia Lawall
2023-10-18 7:32 ` Karolina Stolarek
2023-10-18 7:45 ` Greg Kroah-Hartman
2023-10-18 7:52 ` Karolina Stolarek [this message]
2023-10-18 10:28 ` Julia Lawall
2023-10-18 10:40 ` Karolina Stolarek
2023-10-18 22:17 ` Alison Schofield
2023-10-18 10:42 ` Dan Carpenter
2023-10-18 10:38 ` Andi Shyti
2023-10-18 8:04 ` Karolina Stolarek
2023-10-23 23:09 ` kernel test robot
2023-11-05 20:58 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dde176b-1059-e9a4-a023-0243cce61d01@intel.com \
--to=karolina.stolarek@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=maduechesik@gmail.com \
--cc=outreachy@lists.linux.dev \
--cc=shreeya.patel23498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox