From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A7A33E3C53 for ; Mon, 30 Mar 2026 22:24:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774909506; cv=none; b=rRryCt0TJUuG3VoD7ROY1JvMn8He3Ifoj4NaeUmqEQzxwlshNCj7XkvPaF5eZiUHu8XpP0t51+KwyWM0xCE9URS/NwSOc1MxGzuKG5P8S7gk04wxvMNuBqd1zRBVpyiXmCbV3ieU4KaleDpB6X7JN0DECUeBlAHGY8PZgvyiD+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774909506; c=relaxed/simple; bh=RphenkmKp5cHZbTuPcy3VOdJH9R0n5lebz4MDGW0iN8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y3C+vpms3u5GKocwF2a9KXZ8nmv3S/0Fwj8FRxlqCmnhrb+qbLDUSMvI0RmO42xTeatEpacDkupvE3EQ1PDEcZWnm4ZqkaQdLWq8n2xF1zl3oIkbRZdt6owWop2FP4V3DqAamZSX+2OPPm2H+22PxAeSyYLrcXqVj0H8TXEffwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=kJnhCKUc; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="kJnhCKUc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1774909494; bh=RphenkmKp5cHZbTuPcy3VOdJH9R0n5lebz4MDGW0iN8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kJnhCKUcUJFcI9rTX+8uPRrlKQaxBe70PwrsqkIcSoQI8ZQWxUscNMnrh/LRVlTHE 9hGfYLTHy0+rGNTKUPDou4Mt//azoT9jcZMfoa1OLhOgC7hSfWSPfDiKdcWlkZtN7r ZHfJ5mXIFGPsPbhFUNcghcP4/h1rFA7uIdVDjzhH5wA1hW+dNrjKhV2lNo4CL6w/3b syWWD2s09ujeXhx4eSoI8gVSxOJ7Cy+nfuQsXq0IwcbMHeHZyUS7L6ctlLHfm7vz48 Y12kvdBaZvv9adgrmc3cVXWcGAARz4pZmcJvib1bioJL3e7GXX+ijfh3aWkfQPKjac SKbENZPsI5ZUw== Received: from [192.168.1.57] (host-79-18-8-236.retail.telecomitalia.it [79.18.8.236]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id E3E0517E50D0; Tue, 31 Mar 2026 00:24:53 +0200 (CEST) Message-ID: <7df5a59f-8f66-4764-bc85-59eadd0851f5@collabora.com> Date: Tue, 31 Mar 2026 01:24:53 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v4 4/4] drm/rockchip: dw_hdmi_qp: Do not send HPD events for all connectors To: Heiko Stuebner , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , Andy Yan Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Diederik de Haas , Maud Spierings References: <20260323-dw-hdmi-qp-scramb-v4-0-1d99df84883e@collabora.com> <20260323-dw-hdmi-qp-scramb-v4-4-1d99df84883e@collabora.com> <47972235.fMDQidcC6G@phil> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <47972235.fMDQidcC6G@phil> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/30/26 7:56 PM, Heiko Stuebner wrote: > Am Montag, 23. März 2026, 18:45:30 Mitteleuropäische Sommerzeit schrieb Cristian Ciocaltea: >> In order to optimize the HPD event handling and run the detect cycle on >> the affected connector only, make use of >> drm_connector_helper_hpd_irq_event() instead of >> drm_helper_hpd_irq_event(). >> >> Additionally, move devm_request_threaded_irq() after bridge connector >> initialization. > > nit: Using "and", "additionally", etc in commit messages, is a strong > indicator, things should be separate commits. > > Especially as the sentence above just explains the "what" but not the > why (interrupt firing, before the device is actually there probably). > > If there are no other changes requested, they can stay together though, > the "why" is somewhat obvious here. Ack, will split this up in case a new revision is needed. > > > Both changes themself look fine, so > > Reviewed-by: Heiko Stuebner Thanks for the review! Regards, Cristian