public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: rui.zhang@intel.com, amit.kucheria@verdurent.com,
	amit.kachhap@gmail.com, daniel.lezcano@linaro.org,
	viresh.kumar@linaro.org, len.brown@intel.com, pavel@ucw.cz,
	Pierre.Gondois@arm.com, ionela.voinescu@arm.com,
	mhiramat@kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, rafael@kernel.org
Subject: Re: [PATCH v3 08/12] PM: EM: Introduce runtime modifiable table
Date: Mon, 21 Aug 2023 16:25:47 +0100	[thread overview]
Message-ID: <7dfefc7f-cc86-01a1-2b8a-58e025ecfaf9@arm.com> (raw)
In-Reply-To: <8fa02b18-7e41-eaea-f054-6842f6e310c6@arm.com>



On 8/16/23 14:05, Dietmar Eggemann wrote:
> On 21/07/2023 17:50, Lukasz Luba wrote:
>> This patch introduces the new feature: modifiable EM perf_state table.
> 
> nit pick: The first sentence doesn't add any information. I would skip it.
> 
> [...]
> 
>> The runtime modifiable EM data is used by the Energy Aware Scheduler (EAS)
>> for the task placement. The EAS is the only user of the 'runtime
>> modifiable EM'.
> 
> The runtime modifiable EM is currently only used ...
> The you can skip the next sentence: "The EAS is the only user ..."
> 
> All the other users (thermal, etc.) are still using the
>> default (basic) EM. This fact drove the design of this feature.
> 
> [...]
> 

Thanks, I'll remove them in the next version.

  reply	other threads:[~2023-08-21 15:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 15:50 [PATCH v3 00/12] Introduce runtime modifiable Energy Model Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 01/12] PM: EM: Refactor em_cpufreq_update_efficiencies() arguments Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 02/12] PM: EM: Find first CPU online while updating OPP efficiency Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 03/12] PM: EM: Refactor em_pd_get_efficient_state() to be more flexible Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 04/12] PM: EM: Refactor a new function em_compute_costs() Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 05/12] PM: EM: Check if the get_cost() callback is present in em_compute_costs() Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 06/12] PM: EM: Refactor struct em_perf_domain and add default_table Lukasz Luba
2023-08-16 13:04   ` Dietmar Eggemann
2023-08-21 15:22     ` Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 07/12] PM: EM: Add update_power() callback for runtime modifications Lukasz Luba
2023-08-16 13:04   ` Dietmar Eggemann
2023-08-21 15:23     ` Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 08/12] PM: EM: Introduce runtime modifiable table Lukasz Luba
2023-08-16 13:05   ` Dietmar Eggemann
2023-08-21 15:25     ` Lukasz Luba [this message]
2023-07-21 15:50 ` [PATCH v3 09/12] PM: EM: Add RCU mechanism which safely cleans the old data Lukasz Luba
2023-08-16 13:06   ` Dietmar Eggemann
2023-08-21 15:30     ` Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 10/12] PM: EM: Add runtime update interface to modify EM power Lukasz Luba
2023-08-16 13:07   ` Dietmar Eggemann
2023-08-21 15:33     ` Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 11/12] PM: EM: Use runtime modified EM for CPUs energy estimation in EAS Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 12/12] Documentation: EM: Update with runtime modification design Lukasz Luba
2023-08-16 13:08   ` Dietmar Eggemann
2023-08-21 16:13     ` Lukasz Luba
2023-08-16 13:00 ` [PATCH v3 00/12] Introduce runtime modifiable Energy Model Dietmar Eggemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7dfefc7f-cc86-01a1-2b8a-58e025ecfaf9@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=Pierre.Gondois@arm.com \
    --cc=amit.kachhap@gmail.com \
    --cc=amit.kucheria@verdurent.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=ionela.voinescu@arm.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox