Re: [PATCH net-next 5/7] net: phy: microchip_t1s: add support for Microchip's LAN867X Rev.C1

[<Parthiban.Veerasooran@microchip.com>]

Hi Simon,

On 16/08/24 10:25 pm, Simon Horman wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, Aug 16, 2024 at 01:21:02PM +0000, Parthiban.Veerasooran@microchip.com wrote:
>> On 15/08/24 8:12 pm, Simon Horman wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> On Mon, Aug 12, 2024 at 07:18:14PM +0530, Parthiban Veerasooran wrote:
>>>> This patch adds support for LAN8670/1/2 Rev.C1 as per the latest
>>>> configuration note AN1699 released (Revision E (DS60001699F - June 2024))
>>>> https://www.microchip.com/en-us/application-notes/an1699
>>>>
>>>> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
>>>> ---
>>>>    drivers/net/phy/Kconfig         |  2 +-
>>>>    drivers/net/phy/microchip_t1s.c | 68 ++++++++++++++++++++++++++++++++-
>>>>    2 files changed, 67 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
>>>> index 68db15d52355..63b45544c191 100644
>>>> --- a/drivers/net/phy/Kconfig
>>>> +++ b/drivers/net/phy/Kconfig
>>>> @@ -282,7 +282,7 @@ config MICREL_PHY
>>>>    config MICROCHIP_T1S_PHY
>>>>         tristate "Microchip 10BASE-T1S Ethernet PHYs"
>>>>         help
>>>> -       Currently supports the LAN8670/1/2 Rev.B1 and LAN8650/1 Rev.B0/B1
>>>> +       Currently supports the LAN8670/1/2 Rev.B1/C1 and LAN8650/1 Rev.B0/B1
>>>>           Internal PHYs.
>>>>
>>>>    config MICROCHIP_PHY
>>>> diff --git a/drivers/net/phy/microchip_t1s.c b/drivers/net/phy/microchip_t1s.c
>>>> index d0af02a25d01..62f5ce548c6a 100644
>>>> --- a/drivers/net/phy/microchip_t1s.c
>>>> +++ b/drivers/net/phy/microchip_t1s.c
>>>> @@ -3,7 +3,7 @@
>>>>     * Driver for Microchip 10BASE-T1S PHYs
>>>>     *
>>>>     * Support: Microchip Phys:
>>>> - *  lan8670/1/2 Rev.B1
>>>> + *  lan8670/1/2 Rev.B1/C1
>>>>     *  lan8650/1 Rev.B0/B1 Internal PHYs
>>>>     */
>>>>
>>>> @@ -12,6 +12,7 @@
>>>>    #include <linux/phy.h>
>>>>
>>>>    #define PHY_ID_LAN867X_REVB1 0x0007C162
>>>> +#define PHY_ID_LAN867X_REVC1 0x0007C164
>>>>    /* Both Rev.B0 and B1 clause 22 PHYID's are same due to B1 chip limitation */
>>>>    #define PHY_ID_LAN865X_REVB 0x0007C1B3
>>>>
>>>> @@ -243,7 +244,7 @@ static int lan865x_revb_config_init(struct phy_device *phydev)
>>>>                 if (ret)
>>>>                         return ret;
>>>>
>>>> -             if (i == 2) {
>>>> +             if (i == 1) {
>>>>                         ret = lan865x_setup_cfgparam(phydev, offsets);
>>>>                         if (ret)
>>>>                                 return ret;
>>>
>>> Hi Parthiban,
>>>
>>> This patch is addressing LAN867X Rev.C1 support.
>>> But the hunk above appears to update LAN865X Rev.B0/B1 support.
>>> Is that intentional?
>>
>> Hi Simon,
>>
>> Sorry, there is a mistake here. It is supposed to be "i == 1" only, but
>> it should have been in the below patch onwards,
>>
>> "[PATCH net-next 2/7] net: phy: microchip_t1s: update new initial
>> settings for LAN865X Rev.B0"
>>
>> Thanks for pointing it out. Will correct it in the next version.
> 
> Thanks,
> 
> Other than the minor problem noted above, the patchset looked good to me.
Thanks for your feedback. Its been almost a week since I posted this 
patch series and there are no other comments except this one. Shall I 
update this fix and post the next version of this patch series?

Best regards,
Parthiban V
>