Re: [PATCH 3/4] dt-bindings: clock: Add AST2700 clock bindings

Krzysztof Kozlowski
2024-08-09T06:06:48Z

On 09/08/2024 07:47, Ryan Chen wrote:
>> Subject: Re: [PATCH 3/4] dt-bindings: clock: Add AST2700 clock bindings
>>
>> Le 08/08/2024 à 09:59, Ryan Chen a écrit :
>>> Add dt bindings for AST2700 clock controller
>>>
>>> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
>>> ---
>>> .../dt-bindings/clock/aspeed,ast2700-clk.h | 175
>> ++++++++++++++++++
>>> 1 file changed, 175 insertions(+)
>>> create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h
>>>
>>> diff --git a/include/dt-bindings/clock/aspeed,ast2700-clk.h
>>> b/include/dt-bindings/clock/aspeed,ast2700-clk.h
>>> new file mode 100644
>>> index 000000000000..facf72352c3e
>>> --- /dev/null
>>> +++ b/include/dt-bindings/clock/aspeed,ast2700-clk.h
>>> @@ -0,0 +1,175 @@
>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>> +/*
>>> + * Device Tree binding constants for AST2700 clock controller.
>>> + *
>>> + * Copyright (c) 2024 Aspeed Technology Inc.
>>> + */
>>> +
>>> +#ifndef __DT_BINDINGS_CLOCK_AST2700_H #define
>>> +__DT_BINDINGS_CLOCK_AST2700_H
>>> +
>>> +/* SOC0 clk-gate */
>>> +#define SCU0_CLK_GATE_MCLK (0)
>>> +#define SCU0_CLK_GATE_ECLK (1)
>>> +#define SCU0_CLK_GATE_2DCLK (2)
>>> +#define SCU0_CLK_GATE_VCLK (3)
>>> +#define SCU0_CLK_GATE_BCLK (4)
>>> +#define SCU0_CLK_GATE_VGA0CLK (5)
>>> +#define SCU0_CLK_GATE_REFCLK (6)
>>> +#define SCU0_CLK_GATE_PORTBUSB2CLK (7)
>>> +#define SCU0_CLK_GATE_RSV8 (8)
>>> +#define SCU0_CLK_GATE_UHCICLK (9)
>>> +#define SCU0_CLK_GATE_VGA1CLK (10)
>>> +#define SCU0_CLK_GATE_DDRPHYCLK (11)
>>> +#define SCU0_CLK_GATE_E2M0CLK (12)
>>> +#define SCU0_CLK_GATE_HACCLK (13)
>>> +#define SCU0_CLK_GATE_PORTAUSB2CLK (14)
>>> +#define SCU0_CLK_GATE_UART4CLK (15)
>>> +#define SCU0_CLK_GATE_SLICLK (16)
>>> +#define SCU0_CLK_GATE_DACCLK (17)
>>> +#define SCU0_CLK_GATE_DP (18)
>>> +#define SCU0_CLK_GATE_E2M1CLK (19)
>>> +#define SCU0_CLK_GATE_CRT0CLK (20)
>>> +#define SCU0_CLK_GATE_CRT1CLK (21)
>>> +#define SCU0_CLK_GATE_VLCLK (22)
>>> +#define SCU0_CLK_GATE_ECDSACLK (23)
>>> +#define SCU0_CLK_GATE_RSACLK (24)
>>> +#define SCU0_CLK_GATE_RVAS0CLK (25)
>>> +#define SCU0_CLK_GATE_UFSCLK (26)
>>> +#define SCU0_CLK_GATE_EMMCCLK (27)
>>> +#define SCU0_CLK_GATE_RVAS1CLK (28)
>>> +/* reserved 29 ~ 31*/

No, you cannot reserve IDs. They are always continous.

>>> +#define SCU0_CLK_GATE_NUM (SCU0_CLK_GATE_RVAS1CLK + 1)

No, not a binding.

>>> +
>>> +/* SOC0 clk */
>>> +#define SCU0_CLKIN (SCU0_CLK_GATE_NUM + 0)
>>
>> So SCU0_CLKIN is 28+1+0 = 29 which is said to be reserved in the comment
>> above.
>
> Acutely, I keep reserved is because data sheet has reserved bits from 29~31.
> If you have concern about it, I can remove the comment.
> Or are you prefer by following?
> #define SCU0_CLK_GATE_RESERVED29 (29)
> #define SCU0_CLK_GATE_RESERVED30 (30)
> #define SCU0_CLK_GATE_RESERVED31 (31)
> #define SCU0_CLK_GATE_NUM (SCU0_CLK_GATE_RESERVED31 + 1)
>
>>
>>> +#define SCU0_CLK_24M (SCU0_CLK_GATE_NUM + 1)
>>> +#define SCU0_CLK_192M (SCU0_CLK_GATE_NUM + 2)
>>> +#define SCU0_CLK_UART (SCU0_CLK_GATE_NUM + 3)
>>> +#define SCU0_CLK_PSP (SCU0_CLK_GATE_NUM + 4)
>>> +#define SCU0_CLK_HPLL (SCU0_CLK_GATE_NUM + 5)
>>
>> ...
>
> ************* Email Confidentiality Notice ********************
> 免責聲明:
> 本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作!
>
> DISCLAIMER:
> This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.

Maybe I am the intended recipient of your message, maybe not. I don't
want to have any legal questions regarding upstream, public
collaboration, thus probably I should just remove your messages.

Please talk with your IT that such disclaimers in open-source are not
desired (and maybe even harmful).
If you do not understand why, please also see:
https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835

If you need to go around company SMTP server, then consider using b4
web-relay: https://b4.docs.kernel.org/en/latest/contributor/send.html

Please be informed that by responding to this email you agree that all
communications from you and/or your company is made public. In other
words, all messages originating from you and/or your company will be
made public.

Best regards,
Krzysztof