From: Jens Axboe <axboe@kernel.dk>
To: Bean Huo <beanhuo@iokpp.de>,
kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, beanhuo@micron.com
Subject: Re: [PATCH] nvme: Use command_id instead of req->tag in trace_nvme_complete_rq()
Date: Fri, 15 Jul 2022 13:51:24 -0600 [thread overview]
Message-ID: <7e2c6bc4-8aef-3334-fbbf-d67e7de617fe@kernel.dk> (raw)
In-Reply-To: <20220715194804.324158-1-beanhuo@iokpp.de>
On 7/15/22 1:48 PM, Bean Huo wrote:
> From: Bean Huo <beanhuo@micron.com>
>
> use command_id instead of req->tag in trace_nvme_complete_rq(),
> because of commit e7006de6c238 ("nvme: code command_id with a genctr
> for use authentication after release"), cmd->common.command_id is set to
> ((genctl & 0xf)< 12 | req->tag), no longer req->tag, which makes cid in
> trace_nvme_complete_rq and trace_nvme_setup_cmd are not the same.
Needs a fixes tag.
--
Jens Axboe
prev parent reply other threads:[~2022-07-15 19:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 19:48 [PATCH] nvme: Use command_id instead of req->tag in trace_nvme_complete_rq() Bean Huo
2022-07-15 19:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e2c6bc4-8aef-3334-fbbf-d67e7de617fe@kernel.dk \
--to=axboe@kernel.dk \
--cc=axboe@fb.com \
--cc=beanhuo@iokpp.de \
--cc=beanhuo@micron.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox