From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
Narasimhan.V@amd.com, Borislav Petkov <bp@alien8.de>,
Kim Phillips <kim.phillips@amd.com>
Subject: Re: [PATCH v3 2/7] i2c: designware: Let PCI core to take care about interrupt vectors
Date: Tue, 20 Aug 2024 14:15:15 +0300 [thread overview]
Message-ID: <7e3e71aa-cc07-44a0-963d-8965a7fffd7e@linux.intel.com> (raw)
In-Reply-To: <20240819184600.2256658-3-andriy.shevchenko@linux.intel.com>
On 8/19/24 9:45 PM, Andy Shevchenko wrote:
> PCI core, after pcim_enable_device(), takes care about the allocated
> IRQ vectors, no need to do it explicitly and break the cleaning up
> order.
>
> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/i2c/busses/i2c-designware-pcidrv.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
I wanted to test this due to earlier 9be8bc4dd617 ("i2c: designware-pci:
Fix BUG_ON during device removal").
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2024-08-20 11:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 18:45 From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Andy Shevchenko
2024-08-19 18:45 ` [PATCH v3 1/7] i2c: designware: Replace a while-loop by for-loop Andy Shevchenko
2024-08-19 18:45 ` [PATCH v3 2/7] i2c: designware: Let PCI core to take care about interrupt vectors Andy Shevchenko
2024-08-20 11:15 ` Jarkko Nikula [this message]
2024-08-19 18:45 ` [PATCH v3 3/7] i2c: designware: Add missing 'c' into PCI IDs variable name Andy Shevchenko
2024-08-19 18:45 ` [PATCH v3 4/7] i2c: designware: Unify terminator in device ID tables Andy Shevchenko
2024-08-19 18:45 ` [PATCH v3 5/7] i2c: designware: Always provide " Andy Shevchenko
2024-08-19 18:45 ` [PATCH v3 6/7] i2c: designware: Drop return value from i2c_dw_acpi_configure() Andy Shevchenko
2024-08-19 18:45 ` [PATCH v3 7/7] i2c: designware: Drop return value from dw_i2c_of_configure() Andy Shevchenko
2024-08-19 20:27 ` From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Andi Shyti
2024-08-21 14:11 ` Andi Shyti
2024-08-21 14:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e3e71aa-cc07-44a0-963d-8965a7fffd7e@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=Narasimhan.V@amd.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=jsd@semihalf.com \
--cc=kim.phillips@amd.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox