From: David Ahern <dsahern@gmail.com>
To: Yajun Deng <yajun.deng@linux.dev>,
davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] neigh: use struct {arp, ndisc}_generic_ops for all case
Date: Thu, 28 Oct 2021 09:09:46 -0600 [thread overview]
Message-ID: <7e5514de-01ec-060f-cbc3-1b777e134a54@gmail.com> (raw)
In-Reply-To: <20211028122022.14879-1-yajun.deng@linux.dev>
On 10/28/21 6:20 AM, Yajun Deng wrote:
> diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c
> index 922dd73e5740..9ee59c2e419a 100644
> --- a/net/ipv4/arp.c
> +++ b/net/ipv4/arp.c
> @@ -135,14 +135,6 @@ static const struct neigh_ops arp_generic_ops = {
> .connected_output = neigh_connected_output,
> };
>
> -static const struct neigh_ops arp_hh_ops = {
> - .family = AF_INET,
> - .solicit = arp_solicit,
> - .error_report = arp_error_report,
> - .output = neigh_resolve_output,
> - .connected_output = neigh_resolve_output,
> -};
> -
neigh_ops are used by net/core/neighbour.c; this change breaks those
references.
prev parent reply other threads:[~2021-10-28 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 12:20 [PATCH net-next] neigh: use struct {arp, ndisc}_generic_ops for all case Yajun Deng
2021-10-28 15:09 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e5514de-01ec-060f-cbc3-1b777e134a54@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yajun.deng@linux.dev \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox