From: Russ Weight <russell.h.weight@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jim Wylder <jwylder@google.com>,
"Gerlach, Matthew" <matthew.gerlach@linux.intel.com>,
<linux-kernel@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [BUG] _regmap_raw_write() - divide-by-zero
Date: Fri, 16 Jun 2023 15:51:55 -0700 [thread overview]
Message-ID: <7e556c50-a98c-a715-9b80-209dd79cdc29@intel.com> (raw)
In-Reply-To: <648e22d2-d455-4439-a00d-4042077a8571@sirena.org.uk>
On 6/16/23 15:14, Mark Brown wrote:
> On Fri, Jun 16, 2023 at 02:58:24PM -0700, Russ Weight wrote:
>
>> The origination of the regmap->max_raw_write value is here:
>> https://github.com/torvalds/linux/blob/4973ca29552864a7a047ab8a15611a585827412f/drivers/base/regmap/regmap-spi-avmm.c#L663
>>> .max_raw_write = SPI_AVMM_VAL_SIZE * MAX_WRITE_CNT,
>> SPI_AVMM_VAL_SIZE is defined as 4, and MAX_WRITE_CNT is defined as 1
> This should add in some headroom for the value too.
Thanks for the guidance, Mark. We'll put a patch together to fix up the config.
- Russ
>
> We should also fix the max_raw_write comments since it's a bit confusing
> between users and buses, though AFAICT nothing outside the core ever
> checks.
prev parent reply other threads:[~2023-06-16 22:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 21:58 [BUG] _regmap_raw_write() - divide-by-zero Russ Weight
2023-06-16 22:02 ` Mark Brown
2023-06-16 22:14 ` Mark Brown
2023-06-16 22:39 ` Jim Wylder
2023-06-17 12:13 ` Mark Brown
2023-06-16 22:51 ` Russ Weight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e556c50-a98c-a715-9b80-209dd79cdc29@intel.com \
--to=russell.h.weight@intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jwylder@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox