From: Jens Axboe <axboe@kernel.dk>
To: "Pali Rohár" <pali@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Grzegorz Jaszczyk" <jaz@semihalf.com>,
"Andre Heider" <a.heider@gmail.com>,
"Tomasz Maciej Nowak" <tmn505@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: ahci: mvebu: Make SATA PHY optional for Armada 3720
Date: Fri, 9 Oct 2020 12:48:08 -0600 [thread overview]
Message-ID: <7e60bd4f-46bf-cc13-0705-0431adc699c7@kernel.dk> (raw)
In-Reply-To: <20201009084244.29156-1-pali@kernel.org>
On 10/9/20 2:42 AM, Pali Rohár wrote:
> Older ATF does not provide SMC call for SATA phy power on functionality and
> therefore initialization of ahci_mvebu is failing when older version of ATF
> is using. In this case phy_power_on() function returns -EOPNOTSUPP.
>
> This patch adds a new hflag AHCI_HFLAG_IGN_NOTSUPP_POWER_ON which cause
> that ahci_platform_enable_phys() would ignore -EOPNOTSUPP errors from
> phy_power_on() call.
>
> It fixes initialization of ahci_mvebu on Espressobin boards where is older
> Marvell's Arm Trusted Firmware without SMC call for SATA phy power.
>
> This is regression introduced in commit 8e18c8e58da64 ("arm64: dts: marvell:
> armada-3720-espressobin: declare SATA PHY property") where SATA phy was
> defined and therefore ahci_platform_enable_phys() on Espressobin started
> failing.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-10-09 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 8:42 [PATCH] ata: ahci: mvebu: Make SATA PHY optional for Armada 3720 Pali Rohár
2020-10-09 18:48 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e60bd4f-46bf-cc13-0705-0431adc699c7@kernel.dk \
--to=axboe@kernel.dk \
--cc=a.heider@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=jaz@semihalf.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=pali@kernel.org \
--cc=tmn505@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox