From: Niklas Schnelle <schnelle@linux.ibm.com>
To: Markus Elfring <Markus.Elfring@web.de>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eran Ben Elisha <eranbe@mellanox.com>,
Leon Romanovsky <leon@kernel.org>,
Moshe Shemesh <moshe@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [RFC] net/mlx5: Fix failing fw tracer allocation on s390
Date: Wed, 8 Apr 2020 10:06:44 +0200 [thread overview]
Message-ID: <7eaec712-6427-7adf-98cd-2c4347dd9e85@linux.ibm.com> (raw)
In-Reply-To: <77241c76-4836-3080-7fa6-e65fc3af5106@web.de>
On 4/7/20 5:12 PM, Markus Elfring wrote:
>> On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger kzalloc()
>> allocation as done for the firmware tracer will always fail.
>
> How do you think about to add the tag “Fixes” to the final change description?
>
> Regards,
> Markus
>
You're right that makes a lot of sense, thanks! I guess this should reference
the commit that introduced the debug trace, right?
Best regards,
Niklas
next prev parent reply other threads:[~2020-04-08 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 15:12 [RFC] net/mlx5: Fix failing fw tracer allocation on s390 Markus Elfring
2020-04-08 8:06 ` Niklas Schnelle [this message]
2020-04-08 19:38 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eaec712-6427-7adf-98cd-2c4347dd9e85@linux.ibm.com \
--to=schnelle@linux.ibm.com \
--cc=Markus.Elfring@web.de \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox