From: Helge Deller <deller@gmx.de>
To: Meelis Roos <mroos@linux.ee>
Cc: linux-parisc@vger.kernel.org,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: fs/select.c:991:1: warning: the frame size of 1032 bytes is larger than 1024 bytes
Date: Wed, 13 Sep 2017 00:12:14 +0200 [thread overview]
Message-ID: <7eba246c-c2bd-4d47-41a8-93e43239bb02@gmx.de> (raw)
In-Reply-To: <alpine.LRH.2.21.1709112315350.7844@math.ut.ee>
On 11.09.2017 22:16, Meelis Roos wrote:
>> Meelis, this patch should fix both issues.
>> Can you test?
>
> At least one of the warnings is still there - but I am on a 64-bit
> kernel on RP3440, RP3410 and A500 where I saw this.
Details?
The ones you sent were 32bit issues (with 1024 bytes frame-size-warning):
fs/select.c:991:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=]
arch/parisc/kernel/inventory.c:359:1: warning: the frame size of 1120 bytes is larger than 1024 bytes [-Wframe-larger-than=]
Helge
>>
>> Helge
>>
>> [PATCH] parisc: Fix too large frame size warnings
>>
>> The parisc architecture requires larger stack frames than most other
>> architectures on 32-bit kernels.
>> Increase the default to 1280 bytes for parisc to avoid warnings in
>> do_sys_poll() and pat_memconfig() functions.
>>
>> Signed-off-by: Helge Deller <deller@gmx.de>
>>
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index b19c491cbc4e..2689b7c50c52 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -219,7 +219,8 @@ config FRAME_WARN
>> range 0 8192
>> default 0 if KASAN
>> default 2048 if GCC_PLUGIN_LATENT_ENTROPY
>> - default 1024 if !64BIT
>> + default 1280 if (!64BIT && PARISC)
>> + default 1024 if (!64BIT && !PARISC)
>> default 2048 if 64BIT
>> help
>> Tell gcc to warn at build time for stack frames larger than this.
>>
>
prev parent reply other threads:[~2017-09-12 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 14:22 fs/select.c:991:1: warning: the frame size of 1032 bytes is larger than 1024 bytes Meelis Roos
2017-09-11 19:41 ` Helge Deller
2017-09-11 20:16 ` Meelis Roos
2017-09-12 22:12 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eba246c-c2bd-4d47-41a8-93e43239bb02@gmx.de \
--to=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox