From: <Steen.Hegelund@microchip.com>
To: <linux-arm-kernel@lists.infradead.org>,
<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<Horatiu.Vultur@microchip.com>
Cc: <Lars.Povlsen@microchip.com>, <UNGLinuxDriver@microchip.com>,
<linus.walleij@linaro.org>, <colin.foster@in-advantage.com>
Subject: Re: [PATCH] pinctrl: microchip-sgpio: Fix support for regmap
Date: Thu, 27 Jan 2022 12:42:58 +0000 [thread overview]
Message-ID: <7ebaf35c71a15326a7bd9be2676846050ccc8eb4.camel@microchip.com> (raw)
In-Reply-To: <20220125161245.418882-1-horatiu.vultur@microchip.com>
Good catch Horatiu.
BR
Steen
Acked-by: Steen Hegelund <Steen.Hegelund@microchip.com>
On Tue, 2022-01-25 at 17:12 +0100, Horatiu Vultur wrote:
> Initially the driver accessed the registers using u32 __iomem but then
> in the blamed commit it changed it to use regmap. The problem is that now
> the offset of the registers is not calculated anymore at word offset but
> at byte offset. Therefore make sure to multiply the offset with word size.
>
> Fixes: 2afbbab45c261a ("pinctrl: microchip-sgpio: update to support regmap")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
...
prev parent reply other threads:[~2022-01-27 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 16:12 [PATCH] pinctrl: microchip-sgpio: Fix support for regmap Horatiu Vultur
2022-01-25 16:46 ` Colin Foster
2022-01-27 10:40 ` Horatiu Vultur
2022-01-28 14:19 ` Andy Shevchenko
2022-01-28 21:32 ` Colin Foster
2022-01-27 12:42 ` Steen.Hegelund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ebaf35c71a15326a7bd9be2676846050ccc8eb4.camel@microchip.com \
--to=steen.hegelund@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=Lars.Povlsen@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=colin.foster@in-advantage.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox