Re: [PATCH 26/40] drm/amd/pm/powerplay/hwmgr/hwmgr: Move 'vega12_hwmgr_init()'s prototype to shared header

Alex Deucher
2020-11-30T23:51:41Z

On Thu, Nov 26, 2020 at 8:43 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_hwmgr.c:2862:5: warning: no previous prototype for ‘vega12_hwmgr_init’ [-Wmissing-prototypes]
> 2862 | int vega12_hwmgr_init(struct pp_hwmgr *hwmgr)
> | ^~~~~~~~~~~~~~~~~
>
> Cc: Evan Quan <evan.quan@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied. Thanks!

Alex

> ---
> drivers/gpu/drm/amd/pm/inc/hwmgr.h | 1 +
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/inc/hwmgr.h b/drivers/gpu/drm/amd/pm/inc/hwmgr.h
> index 393e4e76a8961..499f2520b1aa3 100644
> --- a/drivers/gpu/drm/amd/pm/inc/hwmgr.h
> +++ b/drivers/gpu/drm/amd/pm/inc/hwmgr.h
> @@ -830,5 +830,6 @@ int hwmgr_handle_task(struct pp_hwmgr *hwmgr,
>
> int smu7_init_function_pointers(struct pp_hwmgr *hwmgr);
> int smu8_init_function_pointers(struct pp_hwmgr *hwmgr);
> +int vega12_hwmgr_init(struct pp_hwmgr *hwmgr);
>
> #endif /* _HWMGR_H_ */
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c
> index 7999091cca16e..49f8a331eb02e 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c
> @@ -47,7 +47,6 @@ extern const struct pp_smumgr_func smu10_smu_funcs;
> extern const struct pp_smumgr_func vega20_smu_funcs;
>
> extern int vega10_hwmgr_init(struct pp_hwmgr *hwmgr);
> -extern int vega12_hwmgr_init(struct pp_hwmgr *hwmgr);
> extern int vega20_hwmgr_init(struct pp_hwmgr *hwmgr);
> extern int smu10_init_function_pointers(struct pp_hwmgr *hwmgr);
>
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel