From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755068AbcIYKvY (ORCPT ); Sun, 25 Sep 2016 06:51:24 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33909 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753023AbcIYKvU (ORCPT ); Sun, 25 Sep 2016 06:51:20 -0400 From: Marcel Xubuntu X-Google-Original-From: Marcel Xubuntu Subject: Re: Fwd: Re: Patchwork [1/1] staging: ks7010: Attempt to structure and format to standards To: Greg KH References: <4865f87e-83ca-62af-1ff6-63f10e3e6da7@gmail.com> <20160925103439.GA8119@kroah.com> Cc: wsa@the-dreams.de, linux-kernel@vger.kernel.org Message-ID: <7ecbe941-1b14-dba1-c23c-896300769ffd@gmail.com> Date: Sun, 25 Sep 2016 13:59:18 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160925103439.GA8119@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/25/16 12:34, Greg KH wrote: > On Sat, Sep 24, 2016 at 06:08:34PM +0200, Marcel Xubuntu wrote: >> >> Code formatting and structuring. >> >> Signed-off-by: Marcel Ricquier >> >> --- >> >> Tested-by: Marcel Ricquier >> >> Mostly code formatting, unapologetically a stepping stone for a potential >> refactoring with a knowledge seeking, following complete disclosure, >> ultimate goal. >> In case this fails, my backup plan is to have the world's record for the >> quickest kernel patch dismissal, either way it's a win. Did I win ?! > > Why did you repeat this? I like repeating things sometimes. > >> diff --git a/drivers/staging/ks7010/ks7010_sdio.c >> b/drivers/staging/ks7010/ks7010_sdio.c >> index b7337fd..8de2713 100644 >> --- a/drivers/staging/ks7010/ks7010_sdio.c >> +++ b/drivers/staging/ks7010/ks7010_sdio.c >> @@ -14,7 +14,7 @@ >> #include >> #include >> #include >> -#include >> +#include > > Patch is corrupted and can not be applied :( Yes, this was an exercise in reconnaissance. I don't want the name of Ricquier correlated with some meaningless style fixing on code that is beyond repair and provides an entry point for outsiders. > > Also, you didn't read the link I provided in the last review, please do > so and fix up the patch to only do one type of a thing at a time. > (hint, "fix all checkpatch issues" is not one thing...) I did, see above. A real patch is outstanding. > > thanks, thank you! > > greg k-h >