From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Eric Gonçalves" <ghatto404@gmail.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
Date: Wed, 1 Oct 2025 11:19:54 +0200 [thread overview]
Message-ID: <7ef97ace-e46a-44cd-b632-eb7b699c20c2@oss.qualcomm.com> (raw)
In-Reply-To: <20250928045817.37384-1-ghatto404@gmail.com>
On 9/28/25 6:58 AM, Eric Gonçalves wrote:
> The S20 series has additional reserved pins for the fingerprint sensor,
> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
>
> Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> ---
> Changes in v3:
> - Actually fixed <40 4> indentation
> Sorry, I still had my editor on 4 spaces a tab
>
> Changes in v2:
> - "Fixed" the formatting of the <40 4> line
> - Added Fixes tag
> ---
> arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> index 96662bf9e527..7696b147e7da 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> @@ -159,7 +159,8 @@ &pon_resin {
> };
>
> &tlmm {
> - gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
> + gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
> + <40 4>, /* Unused */
the above ',' should be a ';'
Konrad
prev parent reply other threads:[~2025-10-01 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 4:58 [PATCH v3] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins Eric Gonçalves
2025-09-29 2:14 ` Rob Herring (Arm)
2025-10-01 9:19 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef97ace-e46a-44cd-b632-eb7b699c20c2@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ghatto404@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox