From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Fred Chen <fredchen.openbmc@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] ARM: dts: aspeed: santabarbara: add sensor support for extension boards
Date: Wed, 10 Sep 2025 16:39:49 +0930 [thread overview]
Message-ID: <7f04c0f1bbb653de33a6a41175cd16f85778ede5.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250908080220.698158-2-fredchen.openbmc@gmail.com>
Hi Fred,
On Mon, 2025-09-08 at 16:02 +0800, Fred Chen wrote:
> add power monitor and temperature sensors for extension boards in bus 6,
> 8, 10 and 13.
>
> Signed-off-by: Fred Chen <fredchen.openbmc@gmail.com>
> ---
> .../aspeed-bmc-facebook-santabarbara.dts | 824 ++++++++++++++++++
> 1 file changed, 824 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts
> index ee93a971c500..2f5712e9ba9f 100644
*snip*
> @@ -574,6 +606,204 @@ eeprom@52 {
> compatible = "atmel,24c256";
> reg = <0x52>;
> };
> +
> + i2c-mux@71 {
> + compatible = "nxp,pca9546";
> + reg = <0x71>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + i2c-mux-idle-disconnect;
> +
> + i2c6mux0ch0: i2c@0 {
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + temperature-sensor@64 {
> + compatible = "microchip,mcp9600";
> + reg = <0x64>;
> + };
> +
> + temperature-sensor@65 {
> + compatible = "microchip,mcp9600";
> + reg = <0x65>;
> + };
> +
> + temperature-sensor@67 {
> + compatible = "microchip,mcp9600";
> + reg = <0x67>;
> + };
> +
> + i2c-mux@72 {
> + compatible = "nxp,pca9546";
> + reg = <0x72>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + i2c-mux-idle-disconnect;
> +
> + i2c6mux1ch0: i2c@0 {
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + i2c6mux1ch1: i2c@1 {
> + reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + voltage-sensor@48 {
> + compatible = "ti,ads7830";
> + reg = <0x48>;
> + };
> +
> + voltage-sensorr@49 {
> + compatible = "ti,ads7830";
> + reg = <0x49>;
> + };
> +
> + temperature-sensor@4a {
> + compatible = "ti,tmp175";
> + reg = <0x4a>;
> + };
> +
> + temperature-sensor@4b {
> + compatible = "ti,tmp175";
> + reg = <0x4b>;
> + };
> +
> + eeprom@56 {
> + compatible = "atmel,24c256";
> + reg = <0x56>;
> + };
> + };
> + i2c6mux1ch2: i2c@2 {
> + reg = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + i2c6mux1ch3: i2c@3 {
Can you please make sure nodes consistently have empty lines between
them? Bunching them together like you have above degrades the
readability in my opinion.
Please audit the rest of the patch for the problem. Ideally audit the
rest of the devicetree too and send a follow-up patch fixing further
instances.
Andrew
next prev parent reply other threads:[~2025-09-10 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 8:02 [PATCH v3 0/4] Revise Meta Santabarbara devicetree Fred Chen
2025-09-08 8:02 ` [PATCH v3 1/4] ARM: dts: aspeed: santabarbara: add sensor support for extension boards Fred Chen
2025-09-10 7:09 ` Andrew Jeffery [this message]
2025-09-08 8:02 ` [PATCH v3 2/4] ARM: dts: aspeed: santabarbara: Enable MCTP for frontend NIC Fred Chen
2025-09-08 8:02 ` [PATCH v3 3/4] ARM: dts: aspeed: santabarbara: Adjust LED configuration Fred Chen
2025-09-08 8:02 ` [PATCH v3 4/4] ARM: dts: aspeed: santabarbara: add sgpio line name for leak detection Fred Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f04c0f1bbb653de33a6a41175cd16f85778ede5.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fredchen.openbmc@gmail.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox