From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755176AbdKGQxV (ORCPT ); Tue, 7 Nov 2017 11:53:21 -0500 Received: from mout.web.de ([212.227.15.14]:54877 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbdKGQxT (ORCPT ); Tue, 7 Nov 2017 11:53:19 -0500 To: linux-nfs@vger.kernel.org, Anna Schumaker , Trond Myklebust Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH RFC v1] nfs/write: Use common error handling code in nfs_lock_and_join_requests() Message-ID: <7f072f78-eef4-6d87-d233-cee71dac5a32@users.sourceforge.net> Date: Tue, 7 Nov 2017 17:53:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:gE97NCIK8aS+SlKH/pa4UhbaIoeRYynbcdvH1EJjI9lWxAG0DU1 DclCaIv4VYlPF7w0pR+VmgSYfTIuFFs3mw2vpSSqN+8Hz/T7/dpu05FTHrMbO6xNJECqrGX jGzyDRqFmT5V9eVISo2sMD+MmKxPAo2Tlbv7RYPWghN58Zt3lGgccHuCwJY9xNLKj9Hhhsv t7lsbdSPfn0AKR9vKfImw== X-UI-Out-Filterresults: notjunk:1;V01:K0:U3nMqKfUYvo=:D0cRdYiAAGXOrKHdzdDF6J v5F5VzAdUXF9QXwbi7hWujvKXTLY5YKAtmwtjNCx5np4qw/IIZaNF9vRLcpOmWpDdyuYOUj4X 8h946csa96aAaNiwolGELjZXPaG3sXguipayQxYDIhzKfzp/vmG4thwF0bp2e+O2IgSaUmwTb U/cC6ploF9/kLbLqiTaFNfeXWscnvpjoiO6saSe+HTi0nV0fLPcsgR7H+G9wOVeAzuChQfxXL YSHgL1eIhO4bnhKA6heLJiVtTeWLeFG6pttvHH2QN/Se4QkKDXT6UiWZeNWocRrBk5OIw7l5f N2Ue0TV1DciHHwaC0qjuUEhEdDLLtjh18zhXUxyDhQIsSzS7qc+W1gEONgPEr2LHGTH0B6DZX F6qb+eZFgMJ1Mz2O3nP5XIPw1a+McQu2nY7eqEYUKFjfOHxgiKo6iacgnzSEor0uJtmgt8+l2 VYnBJGTLnhyFuOWO5Fq0FEVp/N8k9nzNI7sx2PRKo2tYBLkKX34QvQefiAN1g1v/pneKybwJA kV1uT58FH/4pemfKRMcaJBW/p5IGV4HIzVeenoBpSO4aICa7vwccGXqK9m4FFK/8178WkL2Wt FGn5lut/P7RLexRcf/ET3PZP7J6KBLHfwAhDZ5vGyUFHv51xJoT2KZKWlL4/ed8MAITJFjcyr KnkPkormYe5q3nUO6ahJHxw/+3ORl0sVZFruyY/68h+6VwRa8WNad7E3UQsJA+o3dCssMUK6D JS6c4LxJZyWOBAw+oArXQEhyfLDmGKCZc7hVNfk83xJGRUb/ZKRsGO+Oy2ZHVtN09+c5KTphn rLskKCn1PIM7h0PYvNbvmyeF0K+sL/pEMv13SZp1V+1/zcQwVU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 7 Nov 2017 08:51:00 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- v1 - Request for comments: I can offer another bit of information for a software development discussion. ๐Ÿ’ญ The affected source file can be compiled for the processor architecture โ€œx86_64โ€ by a tool like โ€œGCC 6.4.1+r251631-1.3โ€ from the software distribution โ€œopenSUSE Tumbleweedโ€ with the following command example. my_cc=/usr/bin/gcc-6 \ && my_module=fs/nfs/write.o \ && for XYZ in 0 s 3; do echo " _____ $XYZ _____" \ && my_extra="-O$XYZ" \ && git checkout next-20171102 \ && make -j4 CC="${my_cc}" HOSTCC="${my_cc}" EXTRA_CFLAGS="${my_extra}" allmodconfig "${my_module}" \ && size "${my_module}" \ && git checkout ':/^nfs/write: Use common error handling code in nfs_lock_and_join_requests' \ && make -j4 CC="${my_cc}" HOSTCC="${my_cc}" EXTRA_CFLAGS="${my_extra}" allmodconfig "${my_module}" \ && size "${my_module}"; done ๐Ÿ”ฎ Do you find the following differences worth for further clarification? โ•”โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•คโ•โ•โ•โ•โ•โ•โ•— โ•‘ setting โ”‚ text โ•‘ โ• โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•ชโ•โ•โ•โ•โ•โ•โ•ฃ โ•‘ O0 โ”‚ ??? โ•‘ Compilation failure? โ•‘ Os โ”‚ -17 โ•‘ โ•‘ O3 โ”‚ -16 โ•‘ โ•šโ•โ•โ•โ•โ•โ•โ•โ•โ•โ•งโ•โ•โ•โ•โ•โ•โ• fs/nfs/write.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/fs/nfs/write.c b/fs/nfs/write.c index babebbccae2a..5b5f464f6f2a 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c @@ -487,10 +487,8 @@ nfs_lock_and_join_requests(struct page *page) } ret = nfs_page_group_lock(head); - if (ret < 0) { - nfs_unlock_and_release_request(head); - return ERR_PTR(ret); - } + if (ret < 0) + goto release_request; /* lock each request in the page group */ total_bytes = head->wb_bytes; @@ -515,8 +513,7 @@ nfs_lock_and_join_requests(struct page *page) if (ret < 0) { nfs_unroll_locks(inode, head, subreq); nfs_release_request(subreq); - nfs_unlock_and_release_request(head); - return ERR_PTR(ret); + goto release_request; } } /* @@ -532,8 +529,8 @@ nfs_lock_and_join_requests(struct page *page) nfs_page_group_unlock(head); nfs_unroll_locks(inode, head, subreq); nfs_unlock_and_release_request(subreq); - nfs_unlock_and_release_request(head); - return ERR_PTR(-EIO); + ret = -EIO; + goto release_request; } } @@ -576,6 +573,10 @@ nfs_lock_and_join_requests(struct page *page) /* still holds ref on head from nfs_page_find_head_request * and still has lock on head from lock loop */ return head; + +release_request: + nfs_unlock_and_release_request(head); + return ERR_PTR(ret); } static void nfs_write_error_remove_page(struct nfs_page *req) -- 2.15.0