From: Johannes Berg <johannes@sipsolutions.net>
To: Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Miri Korenblit <miriam.rachel.korenblit@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] wifi: iwlwifi: mvm: d3: Avoid -Wflex-array-member-not-at-end warnings
Date: Mon, 07 Apr 2025 22:34:27 +0200 [thread overview]
Message-ID: <7f16ef040821818a0ac8f35b5636877eb7041bd8.camel@sipsolutions.net> (raw)
In-Reply-To: <202504071310.17CBF96EEA@keescook>
On Mon, 2025-04-07 at 13:15 -0700, Kees Cook wrote:
> lots of quotes
It'd be really good if you could trim the quotes a bit ...
> > + wkc->mac_id_n_color =
> > + cpu_to_le32(FW_CMD_ID_AND_COLOR(mvmvif->id,
> > + mvmvif->color));
> > + wkc->num_keys = 1;
>
> Looks like struct iwl_mvm_wep_key_cmd::num_keys is the counted_by for
> struct iwl_mvm_wep_key_cmd::wep_key?
No no no. I'm still burned by you adding this to various places
elsewhere in the wireless stack, let's not.
Btw, Gustavo, I think it was probably the other iwlwifi patch, but
please also make sure kernel-doc doesn't start complaining, we are
trying keep it that way.
johannes
next prev parent reply other threads:[~2025-04-07 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-05 18:07 [PATCH][next] wifi: iwlwifi: mvm: d3: Avoid -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2025-04-07 20:15 ` Kees Cook
2025-04-07 20:34 ` Johannes Berg [this message]
2025-04-25 21:19 ` Gustavo A. R. Silva
2025-05-13 16:38 ` Korenblit, Miriam Rachel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f16ef040821818a0ac8f35b5636877eb7041bd8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox