From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD5A4C433F5 for ; Mon, 1 Nov 2021 04:28:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4A1B60C51 for ; Mon, 1 Nov 2021 04:28:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229650AbhKAEaq (ORCPT ); Mon, 1 Nov 2021 00:30:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbhKAEap (ORCPT ); Mon, 1 Nov 2021 00:30:45 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05C4DC061714 for ; Sun, 31 Oct 2021 21:28:13 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id l10-20020a17090a4d4a00b001a678eed8abso1726244pjh.3 for ; Sun, 31 Oct 2021 21:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=gv78xz17ZsXRpFTbBnwWITsSEOMIBRoa9DJii1PCRs0=; b=oOgFDmadWvgeyAtFLJNk9XUqyYuNs6m8qOhYSw02HDDK6YDDZ0N6k3sw/s0aI1NhEz hGuewXeznWT+7GGeojwNULBYh0hVq0Nj+WpsbabVniao3fI4LupjsQlDQsd9sxR3i1se B1pZCGDALNQ0yG5XO73EVm5Nxz9osmK4o8B0NX1fgJnw6RT5Ijh/8EoozSyDFlDO+kWr 9BvdLIDqHR93pzIJoRdITei0PcYc+shc+nDJtLXi0Mgq3MqRvsgf9xO1mLYIH761Ets8 x+EDs7Q1oChUxbPsgGSLVQd55KTF2JDLg1wN9BZvDBT0dBhC/0iTaQXrJiCz68dw2axQ s3Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gv78xz17ZsXRpFTbBnwWITsSEOMIBRoa9DJii1PCRs0=; b=8GhDN2YavjoU1xxM8mGwUqQhVxCgA/SMri9GbqtuzJXIfqXGvqWKkO7Xwp0ESEnVsE qNtCHmrgLB89NwmqOzBuo8qlhMw83l1vHbYZWYDbNUH54M0bwKm8cCRyiJKxG1WswNj/ hCqCMt4GEP8dZH+jTZxRzJES93dHd7yC2CXSvcH0en04xd1bxtAZptbXdakrUSoqXMWR 7g4y0ZfXfuclu3vknELZ9cPcQ9Ml/pnql8SWsIhjMxJeRzWMS2Zkr2vGLL5IeUJ1VBau QR1eunmDcsDILKVsx7WJjSbn6IBAY966QTNljlPUk5qS7awz2lWZCDldenC4by9xuSIm KbhA== X-Gm-Message-State: AOAM532ON4IfUjG2acnrUarrwt+8v6ildhUCmU9+pZZnpDEWDz37woxL V9OJfoQNTB/b98cAiI6BY0Y= X-Google-Smtp-Source: ABdhPJz7Tutrdo7gHbAbRXGsyCcLGMBxM10G2PfreR1Z/pb812Dfs8u3wWOdaxQPo6qUofrersYyAA== X-Received: by 2002:a17:90b:1bd2:: with SMTP id oa18mr35240318pjb.164.1635740892316; Sun, 31 Oct 2021 21:28:12 -0700 (PDT) Received: from [192.168.1.2] ([59.95.88.136]) by smtp.gmail.com with ESMTPSA id d12sm13468752pfl.141.2021.10.31.21.28.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 Oct 2021 21:28:11 -0700 (PDT) Message-ID: <7f406b96-fbfd-bd3e-182b-3ca8b3056635@gmail.com> Date: Mon, 1 Nov 2021 09:58:03 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH] staging: r8188eu: os_dep: remove the goto statement Content-Language: en-GB To: Joe Perches , Pavel Skripkin , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com References: From: Saurav Girepunje In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/21 12:47 am, Joe Perches wrote: > On Sun, 2021-10-31 at 21:43 +0300, Pavel Skripkin wrote: >> On 10/31/21 21:10, Saurav Girepunje wrote: >>> Remove the goto statement from rtw_init_drv_sw(). In this function goto >>> can be replace by return statement. As on goto label exit, function >>> only return it is not performing any cleanup. Avoiding goto will >>> improve the function readability. > [] >>> diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c > [] >>> @@ -480,48 +480,34 @@ u8 rtw_init_drv_sw(struct adapter *padapter) >>> { >>> u8 ret8 = _SUCCESS; >> >> Btw, this variable can be removed completely then. It's used only for: >> >> ret8 = rtw_init_default_value(padapter); >> >> with your patch applied, but rtw_init_default_value() always returns >> _SUCCESS. >> >>> -exit: >>> return ret8; >>> } >> >> And just `return _SUCCESS;` here. > > And maybe one day s/_SUCCESS/true/ and s/_FAIL/false/ > with appropriate conversions to bool > > Yes this is another improvement possible on this function. Regards, Saurav