From: Damien Le Moal <dlemoal@kernel.org>
To: Phil Pemberton <philpem@philpem.me.uk>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Niklas Cassel <cassel@kernel.org>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v4 1/7] ata: libata-scsi: add atapi_max_lun module parameter
Date: Tue, 12 May 2026 10:46:39 +0900 [thread overview]
Message-ID: <7f7126d4-0c8d-4f88-9ece-5bbfac2b47c7@kernel.org> (raw)
In-Reply-To: <20260506234548.1974603-2-philpem@philpem.me.uk>
On 5/7/26 08:45, Phil Pemberton wrote:
> Until now libata has hard-coded shost->max_lun = 1 for every ATA host,
> so the SCSI layer never scans past LUN 0. This blocks support for
> the small handful of multi-LUN ATAPI devices (Panasonic LF-1195C and
> COMPAQ PD-1 PD/CD combos export CD on LUN 0 and PD on LUN 1; old
> Nakamichi MJ-x.y CD changers expose one LUN per disc slot, up to 7).
>
> Introduce a libata module parameter, atapi_max_lun, that controls the
> upper bound of the per-host SCSI LUN scan. Default is 1, preserving
> current behaviour exactly: out-of-the-box only LUN 0 is scanned.
> Range is clamped to 1..ATAPI_MAX_LUN (8, the SCSI-2 ceiling).
>
> Subsequent patches gate actual LUN>0 probing on BLIST_FORCELUN, so a
> device must both be on the SCSI device list (or carry the appropriate
> quirk) and run on a host whose atapi_max_lun has been raised before
> any extra LUNs are scanned.
>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Phil Pemberton <philpem@philpem.me.uk>
Looks good, but this does not apply to libata tree for-7.2 / for-next branch.
What is this based on ? Please rebase and resend as I would like to run some tests.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-05-12 1:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 23:45 [PATCH v4 0/7] ata: libata-scsi: multi-LUN ATAPI device support Phil Pemberton
2026-05-06 23:45 ` [PATCH v4 1/7] ata: libata-scsi: add atapi_max_lun module parameter Phil Pemberton
2026-05-12 1:46 ` Damien Le Moal [this message]
2026-05-12 10:02 ` Niklas Cassel
2026-05-12 15:12 ` Phil Pemberton
2026-05-06 23:45 ` [PATCH v4 2/7] ata: libata-scsi: convert dev->sdev to per-LUN array Phil Pemberton
2026-05-06 23:45 ` [PATCH v4 3/7] ata: libata-scsi: route non-zero LUN commands for multi-LUN ATAPI Phil Pemberton
2026-05-06 23:45 ` [PATCH v4 4/7] scsi: add BLIST_NO_LUN_1F blacklist flag Phil Pemberton
2026-05-06 23:45 ` [PATCH v4 5/7] ata: libata-scsi: probe additional LUNs for multi-LUN ATAPI devices Phil Pemberton
2026-05-06 23:45 ` [PATCH v4 6/7] scsi: scsi_devinfo: add COMPAQ PD-1 multi-LUN ATAPI device quirk Phil Pemberton
2026-05-06 23:45 ` [PATCH v4 7/7] scsi: scsi_devinfo: extend BLIST_NO_LUN_1F to MATSHITA and NEC PD-1 variants Phil Pemberton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f7126d4-0c8d-4f88-9ece-5bbfac2b47c7@kernel.org \
--to=dlemoal@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=cassel@kernel.org \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=philpem@philpem.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox