From: David Hildenbrand <david@redhat.com>
To: Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Muchun Song <muchun.song@linux.dev>, Peter Xu <peterx@redhat.com>,
Gavin Guo <gavinguo@igalia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] mm,hugetlb: Rename anon_rmap to new_anon_folio and make it boolean
Date: Mon, 23 Jun 2025 16:13:17 +0200 [thread overview]
Message-ID: <7f8ac35d-89f0-41e7-acfb-bcf54991612e@redhat.com> (raw)
In-Reply-To: <20250620123014.29748-4-osalvador@suse.de>
On 20.06.25 14:30, Oscar Salvador wrote:
> anon_rmap is used to determine whether the new allocated folio is anonymous.
> Rename it to something more meaningul like new_anon_folio and make it boolean,
> as we use it like that.
> While we are at it, drop 'new_pagecache_folio' as 'new_anon_folio' is enough to
> check whether we need to restore the consumed reservation.
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> ---
}
> @@ -6640,7 +6638,8 @@ static vm_fault_t hugetlb_no_page(struct address_space *mapping,
> backout:
> spin_unlock(vmf->ptl);
> backout_unlocked:
> - if (new_folio && !new_pagecache_folio)
> + /* We only need to restore reservations for private mappings */
> + if (new_folio && new_anon_folio)
Could this be simplified to
if (new_anon_folio) {
...
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-06-23 14:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 12:30 [PATCH v2 0/5] Misc rework on hugetlb faulting path Oscar Salvador
2025-06-20 12:30 ` [PATCH v2 1/5] mm,hugetlb: Change mechanism to detect a COW on private mapping Oscar Salvador
2025-06-23 14:09 ` David Hildenbrand
2025-06-25 7:49 ` Oscar Salvador
2025-06-25 10:13 ` David Hildenbrand
2025-06-20 12:30 ` [PATCH v2 2/5] mm,hugetlb: Sort out folio locking in the faulting path Oscar Salvador
2025-06-23 14:11 ` David Hildenbrand
2025-06-25 7:47 ` Oscar Salvador
2025-06-25 20:47 ` Oscar Salvador
2025-06-20 12:30 ` [PATCH v2 3/5] mm,hugetlb: Rename anon_rmap to new_anon_folio and make it boolean Oscar Salvador
2025-06-20 14:28 ` Oscar Salvador
2025-06-23 14:13 ` David Hildenbrand [this message]
2025-06-25 7:43 ` Oscar Salvador
2025-06-20 12:30 ` [PATCH v2 4/5] mm,hugetlb: Drop obsolete comment about non-present pte and second faults Oscar Salvador
2025-06-20 12:30 ` [PATCH v2 5/5] mm,hugetlb: Drop unlikelys from hugetlb_fault Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f8ac35d-89f0-41e7-acfb-bcf54991612e@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gavinguo@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).