From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755468AbdEEVB5 (ORCPT ); Fri, 5 May 2017 17:01:57 -0400 Received: from mout.web.de ([212.227.15.4]:60699 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbdEEVB4 (ORCPT ); Fri, 5 May 2017 17:01:56 -0400 Subject: [PATCH 1/7] kernel-trace: Combine two function calls into one in hist_trigger_entry_print() From: SF Markus Elfring To: Ingo Molnar , Steven Rostedt Cc: LKML , kernel-janitors@vger.kernel.org References: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net> Message-ID: <7f9cad99-4eb5-7b3f-505d-8fa9265f476e@users.sourceforge.net> Date: Fri, 5 May 2017 23:01:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:VUjQj8lTvOS9FvaPlbNXRMmjW7UWPeQhvsEbV3TivctbwzKpQSC ebV43apA0vUSbLGDImRmhINe8/xdd5d3ShrmkUx3VSKxE2M9SNOBMTmBiJIoSbWZkv7c+No kVS4IR6fqRwY9Svo3kwRg2qP9rJnYcICnUDD0tAu8ILq0qe/CnWm2gthcD5DD5qHmnFU7WJ RDYkhilrR9KG8wkePNsEw== X-UI-Out-Filterresults: notjunk:1;V01:K0:fFIenEbvIwE=:gWEK3Juvxvp4UDWh5vbVU7 cj+PL8yfQHbZfU7QuMzwE6d0S7WWzr0puT5WJt4Mu4hCDmqWh99HjjB94x7IUAr4NeeINH5uK +OybrCv8BW/XRE8xJwN73LBPbxZH2qX0ZkpX60cEo8nf2FZQ1n5rtvTF62xstf0wjrYxle5xb IyWKM5rWJNwmP8V6Gm/YAePgrgAuh58GmHmi2azycObX4cgvnomdHvm3ajmxlMD2+IpRvrw5J lV8jG8iCPEy0uqDITS0rmgJOUowJdB9LwavY7pkC21wpx0S3ZjumE96VqsdmEv1lxw5yD3QiH myNkStCfNKFkW/KqNjNYvf2O27iDNqYKEsrATu3hCp+HE71Su0HYbLNt7ZkDWL0wOL1YrEpJB avCCb176oejeSMRB5c6yiF9qtpoWzw+ScKqD0usR5Sf+K4IUxnZw1h8rAdNnGlvW5/6JhKh2F mlRAHe4nfsLCrusrY8KP4j3DN6R0xJdl3/3j3m1yVr7gBvbESlAjUNCkEKQfl5ZgrbLjTBubR huHulWec3ZotULmtLNKc2kbSdimwazHs2LKl68g0EGEqhfzSWwfHYNrokHnNjbaA4bIslJsQa C+EjytTr0XlFX/ZcHsIdWMOx7V77yUDpQkCX0NN8OzoY30oWGua0zBTGMCyxXT0dl7G+8mPLb sAzO0ZrPaECqiuYf3l8j3NgkabV3+3LwFSg5ahw0Grysgez8whV6OcmbEPzvsJnnnLcWUn42i OUN8EbYmkZroEpDUgrRpq5m/0Ac2EAQ3hXAp6gSipucpIfoDtnnpnD1QDPVpARLY0x01kjczp YziHEH5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 5 May 2017 19:40:39 +0200 A bit of data was put into a sequence by two separate function calls. Print the same data by a single function call instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- kernel/trace/trace_events_hist.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index 1c21d0e2a145..94999934ffd5 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -1017,7 +1017,5 @@ hist_trigger_entry_print(struct seq_file *m, - seq_puts(m, "}"); - - seq_printf(m, " hitcount: %10llu", + seq_printf(m, "} hitcount: %10llu", tracing_map_read_sum(elt, HITCOUNT_IDX)); for (i = 1; i < hist_data->n_vals; i++) { -- 2.12.2