From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] serial: pic32_uart: Utilize uart_console_enabled()
Date: Wed, 10 Aug 2022 11:26:05 +0300 (EEST) [thread overview]
Message-ID: <7fb01d46-b67-2eff-d54d-c96b079dc5c@linux.intel.com> (raw)
In-Reply-To: <20220806225643.40897-1-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
On Sun, 7 Aug 2022, Andy Shevchenko wrote:
> The serial core already provides a helper to check if the given port
> is an enabled console. Utilize it instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
> ---
> drivers/tty/serial/pic32_uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/pic32_uart.c b/drivers/tty/serial/pic32_uart.c
> index f418f1de66b3..1562c2a48467 100644
> --- a/drivers/tty/serial/pic32_uart.c
> +++ b/drivers/tty/serial/pic32_uart.c
> @@ -943,7 +943,7 @@ static int pic32_uart_probe(struct platform_device *pdev)
> }
>
> #ifdef CONFIG_SERIAL_PIC32_CONSOLE
> - if (uart_console(port) && (pic32_console.flags & CON_ENABLED)) {
> + if (uart_console_enabled(port)) {
> /* The peripheral clock has been enabled by console_setup,
> * so disable it till the port is used.
> */
>
prev parent reply other threads:[~2022-08-10 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 22:56 [PATCH v1 1/2] serial: pic32_uart: Utilize uart_console_enabled() Andy Shevchenko
2022-08-06 22:56 ` [PATCH v1 2/2] serial: pic32_uart: Convert to use GPIO descriptors Andy Shevchenko
2022-08-10 8:26 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fb01d46-b67-2eff-d54d-c96b079dc5c@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox