* [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_PRODUCT_VERSION string
@ 2023-08-08 6:18 Peter Ujfalusi
2023-08-08 9:37 ` Péter Ujfalusi
2023-08-10 15:09 ` Jarkko Sakkinen
0 siblings, 2 replies; 4+ messages in thread
From: Peter Ujfalusi @ 2023-08-08 6:18 UTC (permalink / raw)
To: peterhuewe, jarkko
Cc: jgg, linux-integrity, linux-kernel, l.sanfilippo, peter.ujfalusi,
jsnitsel, pmenzel
The patch which made it to the kernel somehow lost the "01" from the
string, making the match to not work anymore.
Link: https://lore.kernel.org/lkml/20230524085844.11580-1-peter.ujfalusi@linux.intel.com/
Fixes: edb13d7bb034 ("tpm: tpm_tis: Disable interrupts *only* for AEON UPX-i11")
---
Hi Jarkko,
Can you send this patch for the 6.5 cycle?
edb13d7bb034 was applied in 6.5-rc3 and I just updated my work tree to notice
the regression.
Thank you,
Peter
drivers/char/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index ac4daaf294a3..2bb9901a329a 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -183,7 +183,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
.ident = "UPX-TGL",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
- DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL01"),
},
},
{}
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_PRODUCT_VERSION string
2023-08-08 6:18 [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_PRODUCT_VERSION string Peter Ujfalusi
@ 2023-08-08 9:37 ` Péter Ujfalusi
2023-08-10 15:12 ` Jarkko Sakkinen
2023-08-10 15:09 ` Jarkko Sakkinen
1 sibling, 1 reply; 4+ messages in thread
From: Péter Ujfalusi @ 2023-08-08 9:37 UTC (permalink / raw)
To: peterhuewe, jarkko
Cc: jgg, linux-integrity, linux-kernel, l.sanfilippo, jsnitsel,
pmenzel
On 08/08/2023 09:18, Peter Ujfalusi wrote:
> The patch which made it to the kernel somehow lost the "01" from the
> string, making the match to not work anymore.
>
> Link: https://lore.kernel.org/lkml/20230524085844.11580-1-peter.ujfalusi@linux.intel.com/
> Fixes: edb13d7bb034 ("tpm: tpm_tis: Disable interrupts *only* for AEON UPX-i11")
> ---
> Hi Jarkko,
>
> Can you send this patch for the 6.5 cycle?
> edb13d7bb034 was applied in 6.5-rc3 and I just updated my work tree to notice
> the regression.
>
> Thank you,
> Peter
>
> drivers/char/tpm/tpm_tis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index ac4daaf294a3..2bb9901a329a 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -183,7 +183,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
> .ident = "UPX-TGL",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
> - DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL01"),
The DMI property also got changed in the applied patch, it should have
been DMI_PRODUCT_NAME, I will send v2 shortly, please ignore this version
> },
> },
> {}
--
Péter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_PRODUCT_VERSION string
2023-08-08 6:18 [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_PRODUCT_VERSION string Peter Ujfalusi
2023-08-08 9:37 ` Péter Ujfalusi
@ 2023-08-10 15:09 ` Jarkko Sakkinen
1 sibling, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2023-08-10 15:09 UTC (permalink / raw)
To: Peter Ujfalusi, peterhuewe
Cc: jgg, linux-integrity, linux-kernel, l.sanfilippo, jsnitsel,
pmenzel
On Tue Aug 8, 2023 at 9:18 AM EEST, Peter Ujfalusi wrote:
> The patch which made it to the kernel somehow lost the "01" from the
> string, making the match to not work anymore.
>
> Link: https://lore.kernel.org/lkml/20230524085844.11580-1-peter.ujfalusi@linux.intel.com/
> Fixes: edb13d7bb034 ("tpm: tpm_tis: Disable interrupts *only* for AEON UPX-i11")
> ---
> Hi Jarkko,
>
> Can you send this patch for the 6.5 cycle?
> edb13d7bb034 was applied in 6.5-rc3 and I just updated my work tree to notice
> the regression.
>
> Thank you,
> Peter
>
> drivers/char/tpm/tpm_tis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index ac4daaf294a3..2bb9901a329a 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -183,7 +183,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
> .ident = "UPX-TGL",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
> - DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL01"),
> },
> },
> {}
Yes. I'm sending a PR for v6.5-rc6 tomorrow anyhow.
BR, Jarkko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_PRODUCT_VERSION string
2023-08-08 9:37 ` Péter Ujfalusi
@ 2023-08-10 15:12 ` Jarkko Sakkinen
0 siblings, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2023-08-10 15:12 UTC (permalink / raw)
To: Péter Ujfalusi, peterhuewe
Cc: jgg, linux-integrity, linux-kernel, l.sanfilippo, jsnitsel,
pmenzel
On Tue Aug 8, 2023 at 12:37 PM EEST, Péter Ujfalusi wrote:
>
>
> On 08/08/2023 09:18, Peter Ujfalusi wrote:
> > The patch which made it to the kernel somehow lost the "01" from the
> > string, making the match to not work anymore.
> >
> > Link: https://lore.kernel.org/lkml/20230524085844.11580-1-peter.ujfalusi@linux.intel.com/
> > Fixes: edb13d7bb034 ("tpm: tpm_tis: Disable interrupts *only* for AEON UPX-i11")
> > ---
> > Hi Jarkko,
> >
> > Can you send this patch for the 6.5 cycle?
> > edb13d7bb034 was applied in 6.5-rc3 and I just updated my work tree to notice
> > the regression.
> >
> > Thank you,
> > Peter
> >
> > drivers/char/tpm/tpm_tis.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> > index ac4daaf294a3..2bb9901a329a 100644
> > --- a/drivers/char/tpm/tpm_tis.c
> > +++ b/drivers/char/tpm/tpm_tis.c
> > @@ -183,7 +183,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
> > .ident = "UPX-TGL",
> > .matches = {
> > DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
> > - DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL"),
> > + DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL01"),
>
> The DMI property also got changed in the applied patch, it should have
> been DMI_PRODUCT_NAME, I will send v2 shortly, please ignore this version
sure
BR, Jarkko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-10 15:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-08 6:18 [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_PRODUCT_VERSION string Peter Ujfalusi
2023-08-08 9:37 ` Péter Ujfalusi
2023-08-10 15:12 ` Jarkko Sakkinen
2023-08-10 15:09 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox