From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-kernel@lists.codethink.co.uk, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Bin Meng <bmeng.cn@gmail.com>
Subject: Re: [PATCH] riscv: add correct as-options for assembly in modules
Date: Mon, 10 Jan 2022 15:51:07 +0000 [thread overview]
Message-ID: <7ff4062a-4ed0-2cf8-cbe9-c446f79fac39@codethink.co.uk> (raw)
In-Reply-To: <20211208192607.660787-1-ben.dooks@codethink.co.uk>
On 08/12/2021 19:26, Ben Dooks wrote:
> When trying to load modules built for riscv which include assembly
> the kernel loader errors with "unexpected relocation type 'R_RISCV_ALIGN'"
> due to R_RISCV_ALIGN relocations being generated by the assembler.
>
> In commit 7a8e7da42250138 ("RISC-V: Fixes to module loading") the
> CFLAGS have -mno-relax added. This however does not get applied to
> KBUILD_AFLAGS_MODULE so when a module builds a .S file, the -mno-relax
> is not passed and the above error is seen. Fix it by adding the flags
> '-Wa,-mno-relax' to KBUILD_AFLAGS_MODULE.
>
> This may have been fixed in gcc, in:
> https://github.com/gcc-mirror/gcc/commit/3b0a7d624e64eeb81e4d5e8c62c46d86ef521857
Can I just check this can be included in the next release?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
next prev parent reply other threads:[~2022-01-10 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 19:26 [PATCH] riscv: add correct as-options for assembly in modules Ben Dooks
2022-01-10 15:51 ` Ben Dooks [this message]
2022-01-11 7:41 ` Bin Meng
-- strict thread matches above, loose matches on Subject: below --
2022-05-29 15:19 Ben Dooks
2022-05-29 15:23 ` Ben Dooks
2021-07-12 17:48 Ben Dooks
2021-07-16 10:23 ` Ben Dooks
2021-07-16 10:44 ` Bin Meng
2021-07-16 15:33 ` Ben Dooks
2021-07-16 22:37 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ff4062a-4ed0-2cf8-cbe9-c446f79fac39@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=aou@eecs.berkeley.edu \
--cc=bmeng.cn@gmail.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox