Re: [PATCH v2 14/17] ata: ahci_tegra: remove power sequence from driver

Vince Hsu
2015-03-12T12:23:04Z

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Cc'd Hans.

Thanks,
Vince

On 03/12/2015 08:19 PM, Tejun Heo wrote:
> On Thu, Mar 12, 2015 at 08:15:15PM +0800, Vince Hsu wrote:
>> We have the generic PM domain support for Tegra SoCs now. So remove the
>> duplicated sequence here.
>>
>> Signed-off-by: Vince Hsu <vinceh@nvidia.com>
> Can you please repost this patch w/ Hans de Goede
> <hdegoede@redhat.com> cc'd? Just reposting the patch as a reply to
> itself w/ the cc added should do.
>
> Thanks.
>

[-- Attachment #2: 0014-ata-ahci_tegra-remove-power-sequence-from-driver.patch --]
[-- Type: text/x-patch, Size: 1619 bytes --]

>From afff7ff2011f2c3f159726ffddeaeec8f62f013e Mon Sep 17 00:00:00 2001
From: Vince Hsu <vinceh@nvidia.com>
Date: Wed, 14 Jan 2015 11:01:06 +0800
Subject: [PATCH v2 14/17] ata: ahci_tegra: remove power sequence from driver
X-NVConfidentiality: public

We have the generic PM domain support for Tegra SoCs now. So remove the
duplicated sequence here.

Signed-off-by: Vince Hsu <vinceh@nvidia.com>
---
drivers/ata/ahci_tegra.c | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
index 3a62eb246d80..8151587ddb70 100644
--- a/drivers/ata/ahci_tegra.c
+++ b/drivers/ata/ahci_tegra.c
@@ -120,12 +120,6 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv)
if (ret)
return ret;

- ret = tegra_powergate_sequence_power_up(TEGRA_POWERGATE_SATA,
- tegra->sata_clk,
- tegra->sata_rst);
- if (ret)
- goto disable_regulators;
-
reset_control_assert(tegra->sata_oob_rst);
reset_control_assert(tegra->sata_cold_rst);

@@ -140,10 +134,6 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv)

disable_power:
clk_disable_unprepare(tegra->sata_clk);
-
- tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
-
-disable_regulators:
regulator_bulk_disable(ARRAY_SIZE(tegra->supplies), tegra->supplies);

return ret;
@@ -160,7 +150,6 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
reset_control_assert(tegra->sata_cold_rst);

clk_disable_unprepare(tegra->sata_clk);
- tegra_powergate_power_off(TEGRA_POWERGATE_SATA);

regulator_bulk_disable(ARRAY_SIZE(tegra->supplies), tegra->supplies);
}
--
2.1.4