Re: [PATCH v2 17/17] soc/tegra: remove lagacy powergate APIs

Thierry Reding
2015-03-12T12:45:10Z

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

On Thu, Mar 12, 2015 at 08:15:18PM +0800, Vince Hsu wrote:
> We switch to generic power domain now. So remove the legacy functions.
>
> Signed-off-by: Vince Hsu <vinceh@nvidia.com>
> ---
> drivers/soc/tegra/pmc.c | 68 -------------------------------------------------
> include/soc/tegra/pmc.h | 22 ----------------
> 2 files changed, 90 deletions(-)

I don't think we can do this. What if somebody updates their kernel but
not the DTB? In that case they'll end up with drivers that don't enable
power partitions but at the same time the powergate driver won't enable
them either because it is missing the corresponding nodes in the DTB.

What we'll have to do is probably keep the code that enables the power
partitions and make it conditional on the power domains somehow. Is
there a way to determine at runtime whether a device has been attached
to a power domain?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]