Re: [PATCH] driver core: silence device link messages unless debugging

Rafael J. Wysocki
2019-01-11T09:41:45Z

On Fri, Dec 21, 2018 at 5:23 PM Jerome Brunet <jbrunet@baylibre.com> wrote:
>
> On platforms making a fair use of regulators, the dev_info() messages
> coming from the device link function are a bit too verbose. The amount
> of message will increase further with the clock framework joining the
> device link party.
>
> These messages looks valuable for people debugging device link related
> issues, so dev_dbg() looks more appropriate than dev_info().
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> ---
> drivers/base/core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 04bbcd779e11..8d330f921ad7 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -301,7 +301,7 @@ struct device_link *device_link_add(struct device *consumer,
> list_add_tail_rcu(&link->s_node, &supplier->links.consumers);
> list_add_tail_rcu(&link->c_node, &consumer->links.suppliers);
>
> - dev_info(consumer, "Linked as a consumer to %s\n", dev_name(supplier));
> + dev_dbg(consumer, "Linked as a consumer to %s\n", dev_name(supplier));
>
> out:
> device_pm_unlock();
> @@ -327,8 +327,8 @@ static void __device_link_del(struct kref *kref)
> {
> struct device_link *link = container_of(kref, struct device_link, kref);
>
> - dev_info(link->consumer, "Dropping the link to %s\n",
> - dev_name(link->supplier));
> + dev_dbg(link->consumer, "Dropping the link to %s\n",
> + dev_name(link->supplier));
>
> if (link->flags & DL_FLAG_PM_RUNTIME)
> pm_runtime_drop_link(link->consumer);
> --
> 2.19.2
>