[PATCH 0/3] arm64: arch_k3: Removed ti mailbox and sci select

[PATCH 0/3] arm64: arch_k3: Removed ti mailbox and sci select

[Nicolas Frayer]

Removing the automatic selection of the TI message manager and the
TI sci protocol drivers from ARCH_K3 to allow module build support.
Set these 2 drivers as ARCH_K3 for the default selection.
Tested on a TI AM62x SK board.

Nicolas Frayer (3):
  arm64: arch_k3: Removed ti mailbox and sci select
  mailbox: config: ti-msgmgr: Default set to ARCH_K3 for TI msg manager
  firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver

 arch/arm64/Kconfig.platforms | 2 --
 drivers/firmware/Kconfig     | 1 +
 drivers/mailbox/Kconfig      | 1 +
 3 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.25.1

[PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select

[Nicolas Frayer]

In order to build ti mailbox and ti sci as modules,
remove their automatic selection by ARCH_K3

Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
---
 arch/arm64/Kconfig.platforms | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 912529ac58b3..5f16eb498dbf 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -126,8 +126,6 @@ config ARCH_K3
 	select PM_GENERIC_DOMAINS if PM
 	select MAILBOX
 	select SOC_TI
-	select TI_MESSAGE_MANAGER
-	select TI_SCI_PROTOCOL
 	select TI_SCI_INTR_IRQCHIP
 	select TI_SCI_INTA_IRQCHIP
 	help
-- 
2.25.1

Re: [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select

[Vignesh Raghavendra]

On 23/11/22 1:52 am, Nicolas Frayer wrote:
> In order to build ti mailbox and ti sci as modules,
> remove their automatic selection by ARCH_K3
> 

$Subject: s/Removed/Remove,
s/ti/TI
s/sci/SCI

> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
> ---
>  arch/arm64/Kconfig.platforms | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 912529ac58b3..5f16eb498dbf 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -126,8 +126,6 @@ config ARCH_K3
>  	select PM_GENERIC_DOMAINS if PM
>  	select MAILBOX
>  	select SOC_TI
> -	select TI_MESSAGE_MANAGER
> -	select TI_SCI_PROTOCOL
>  	select TI_SCI_INTR_IRQCHIP
>  	select TI_SCI_INTA_IRQCHIP
>  	help


Why not use "imply" instead of "select". This should allow TI_SCI*
drivers to be built as modules if required. Would make 2/3 and 3/3
redundant.

Also, note that 1/3, 2/3 and 3/3 have to go through 3 different trees,
so not a great idea to post as a single series.

Regards
Vignesh

Re: [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select

[Nicolas Frayer]

Le jeu. 24 nov. 2022 à 15:29, Vignesh Raghavendra <vigneshr@ti.com> a écrit :
>
>
>
> On 23/11/22 1:52 am, Nicolas Frayer wrote:
> > In order to build ti mailbox and ti sci as modules,
> > remove their automatic selection by ARCH_K3
> >
>
> $Subject: s/Removed/Remove,
> s/ti/TI
> s/sci/SCI
>
> > Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
> > ---
> >  arch/arm64/Kconfig.platforms | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> > index 912529ac58b3..5f16eb498dbf 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -126,8 +126,6 @@ config ARCH_K3
> >       select PM_GENERIC_DOMAINS if PM
> >       select MAILBOX
> >       select SOC_TI
> > -     select TI_MESSAGE_MANAGER
> > -     select TI_SCI_PROTOCOL
> >       select TI_SCI_INTR_IRQCHIP
> >       select TI_SCI_INTA_IRQCHIP
> >       help
>
>
> Why not use "imply" instead of "select". This should allow TI_SCI*
> drivers to be built as modules if required. Would make 2/3 and 3/3
> redundant.
>
> Also, note that 1/3, 2/3 and 3/3 have to go through 3 different trees,
> so not a great idea to post as a single series.
>
> Regards
> Vignesh

Thanks Vignesh, I'll send a v2 using imply and drop 2/3 and 3/3

[PATCH 2/3] mailbox: config: ti-msgmgr: Default set to ARCH_K3 for TI msg manager

[Nicolas Frayer]

Defaulting the build to ARCH_K3 for the TI message manager driver.

Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
---
 drivers/mailbox/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index d7af896cbd7b..04c442532b70 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -136,6 +136,7 @@ config STI_MBOX
 config TI_MESSAGE_MANAGER
 	tristate "Texas Instruments Message Manager Driver"
 	depends on ARCH_KEYSTONE || ARCH_K3
+	default ARCH_K3
 	help
 	  An implementation of Message Manager slave driver for Keystone
 	  and K3 architecture SoCs from Texas Instruments. Message Manager
-- 
2.25.1

[PATCH 3/3] firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver

[Nicolas Frayer]

Defaulting the build to ARCH_K3 for the TI SCI driver.

Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
---
 drivers/firmware/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index b59e3041fd62..9e29055f62ba 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -261,6 +261,7 @@ config SYSFB_SIMPLEFB
 config TI_SCI_PROTOCOL
 	tristate "TI System Control Interface (TISCI) Message Protocol"
 	depends on TI_MESSAGE_MANAGER
+	default ARCH_K3
 	help
 	  TI System Control Interface (TISCI) Message Protocol is used to manage
 	  compute systems such as ARM, DSP etc with the system controller in
-- 
2.25.1

Re: [PATCH 0/3] arm64: arch_k3: Removed ti mailbox and sci select

[Kevin Hilman]

Nicolas Frayer <nfrayer@baylibre.com> writes:

> Removing the automatic selection of the TI message manager and the
> TI sci protocol drivers from ARCH_K3 to allow module build support.
> Set these 2 drivers as ARCH_K3 for the default selection.
> Tested on a TI AM62x SK board.

Reviewed-by: Kevin Hilman <khilman@baylibre.com>

In the future, please include linux-omap@vger.kernel.org list, which is
where more developers for these K3 platforms hang out and you might get
more review & testing.

Thanks,

Kevin