* [PATCH v3] dmaengine: ti: k3-udma: Deferring probe when soc_device_match() returns NULL
@ 2022-11-17 18:44 Nicolas Frayer
2022-11-18 20:11 ` Kevin Hilman
2022-12-28 11:16 ` Vinod Koul
0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Frayer @ 2022-11-17 18:44 UTC (permalink / raw)
To: peter.ujfalusi, vkoul, dmaengine, linux-kernel; +Cc: khilman, glaroque, nfrayer
When the k3 socinfo driver is built as a module, there is a possibility
that it will probe after the k3 udma driver and the later returns -ENODEV.
By deferring the k3 udma probe we allow the k3 socinfo to probe and
register the soc_device_attribute structure needed by the k3 udma driver.
Removed the dev_err() message as well as it's deferring and not failing.
Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
---
v1->v2:
Extracted this patch from the following series:
https://lore.kernel.org/all/20221108181144.433087-1-nfrayer@baylibre.com/
v2->v3:
Removed the dev_err() message
drivers/dma/ti/k3-udma.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index ce8b80bb34d7..ca1512eb9910 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -5271,10 +5271,10 @@ static int udma_probe(struct platform_device *pdev)
ud->match_data = match->data;
soc = soc_device_match(k3_soc_devices);
- if (!soc) {
- dev_err(dev, "No compatible SoC found\n");
- return -ENODEV;
- }
+
+ if (!soc)
+ return -EPROBE_DEFER;
+
ud->soc_data = soc->data;
ret = udma_get_mmrs(pdev, ud);
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v3] dmaengine: ti: k3-udma: Deferring probe when soc_device_match() returns NULL
2022-11-17 18:44 [PATCH v3] dmaengine: ti: k3-udma: Deferring probe when soc_device_match() returns NULL Nicolas Frayer
@ 2022-11-18 20:11 ` Kevin Hilman
2022-12-28 11:16 ` Vinod Koul
1 sibling, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2022-11-18 20:11 UTC (permalink / raw)
To: Nicolas Frayer, peter.ujfalusi, vkoul, dmaengine, linux-kernel
Cc: glaroque, nfrayer
Nicolas Frayer <nfrayer@baylibre.com> writes:
> When the k3 socinfo driver is built as a module, there is a possibility
> that it will probe after the k3 udma driver and the later returns -ENODEV.
> By deferring the k3 udma probe we allow the k3 socinfo to probe and
> register the soc_device_attribute structure needed by the k3 udma driver.
> Removed the dev_err() message as well as it's deferring and not failing.
>
> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] dmaengine: ti: k3-udma: Deferring probe when soc_device_match() returns NULL
2022-11-17 18:44 [PATCH v3] dmaengine: ti: k3-udma: Deferring probe when soc_device_match() returns NULL Nicolas Frayer
2022-11-18 20:11 ` Kevin Hilman
@ 2022-12-28 11:16 ` Vinod Koul
2022-12-29 16:29 ` Péter Ujfalusi
1 sibling, 1 reply; 5+ messages in thread
From: Vinod Koul @ 2022-12-28 11:16 UTC (permalink / raw)
To: Nicolas Frayer; +Cc: peter.ujfalusi, dmaengine, linux-kernel, khilman, glaroque
On 17-11-22, 19:44, Nicolas Frayer wrote:
> When the k3 socinfo driver is built as a module, there is a possibility
> that it will probe after the k3 udma driver and the later returns -ENODEV.
> By deferring the k3 udma probe we allow the k3 socinfo to probe and
> register the soc_device_attribute structure needed by the k3 udma driver.
> Removed the dev_err() message as well as it's deferring and not failing.
lgtm, but need rebase as I already picked commit 3f58e10615f3 dmaengine: ti:
k3-udma: Add support for BCDMA CSI RX
>
> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
> ---
> v1->v2:
> Extracted this patch from the following series:
> https://lore.kernel.org/all/20221108181144.433087-1-nfrayer@baylibre.com/
>
> v2->v3:
> Removed the dev_err() message
>
> drivers/dma/ti/k3-udma.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index ce8b80bb34d7..ca1512eb9910 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -5271,10 +5271,10 @@ static int udma_probe(struct platform_device *pdev)
> ud->match_data = match->data;
>
> soc = soc_device_match(k3_soc_devices);
> - if (!soc) {
> - dev_err(dev, "No compatible SoC found\n");
> - return -ENODEV;
> - }
> +
> + if (!soc)
> + return -EPROBE_DEFER;
> +
> ud->soc_data = soc->data;
>
> ret = udma_get_mmrs(pdev, ud);
> --
> 2.25.1
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] dmaengine: ti: k3-udma: Deferring probe when soc_device_match() returns NULL
2022-12-28 11:16 ` Vinod Koul
@ 2022-12-29 16:29 ` Péter Ujfalusi
2022-12-29 23:31 ` Nicolas Frayer
0 siblings, 1 reply; 5+ messages in thread
From: Péter Ujfalusi @ 2022-12-29 16:29 UTC (permalink / raw)
To: Vinod Koul, Nicolas Frayer; +Cc: dmaengine, linux-kernel, khilman, glaroque
On 28/12/2022 13:16, Vinod Koul wrote:
> On 17-11-22, 19:44, Nicolas Frayer wrote:
>> When the k3 socinfo driver is built as a module, there is a possibility
>> that it will probe after the k3 udma driver and the later returns -ENODEV.
>> By deferring the k3 udma probe we allow the k3 socinfo to probe and
>> register the soc_device_attribute structure needed by the k3 udma driver.
>> Removed the dev_err() message as well as it's deferring and not failing.
>
> lgtm, but need rebase as I already picked commit 3f58e10615f3 dmaengine: ti:
> k3-udma: Add support for BCDMA CSI RX
Is this path needed at all? afaik the k3 socinfo is not going to be
module built.
>
>>
>> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
>> ---
>> v1->v2:
>> Extracted this patch from the following series:
>> https://lore.kernel.org/all/20221108181144.433087-1-nfrayer@baylibre.com/
>>
>> v2->v3:
>> Removed the dev_err() message
>>
>> drivers/dma/ti/k3-udma.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
>> index ce8b80bb34d7..ca1512eb9910 100644
>> --- a/drivers/dma/ti/k3-udma.c
>> +++ b/drivers/dma/ti/k3-udma.c
>> @@ -5271,10 +5271,10 @@ static int udma_probe(struct platform_device *pdev)
>> ud->match_data = match->data;
>>
>> soc = soc_device_match(k3_soc_devices);
>> - if (!soc) {
>> - dev_err(dev, "No compatible SoC found\n");
>> - return -ENODEV;
>> - }
>> +
>> + if (!soc)
>> + return -EPROBE_DEFER;
>> +
>> ud->soc_data = soc->data;
>>
>> ret = udma_get_mmrs(pdev, ud);
>> --
>> 2.25.1
>
--
Péter
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] dmaengine: ti: k3-udma: Deferring probe when soc_device_match() returns NULL
2022-12-29 16:29 ` Péter Ujfalusi
@ 2022-12-29 23:31 ` Nicolas Frayer
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Frayer @ 2022-12-29 23:31 UTC (permalink / raw)
To: Péter Ujfalusi
Cc: Vinod Koul, dmaengine, linux-kernel, khilman, glaroque
Le jeu. 29 déc. 2022 à 17:27, Péter Ujfalusi
<peter.ujfalusi@gmail.com> a écrit :
>
>
>
> On 28/12/2022 13:16, Vinod Koul wrote:
> > On 17-11-22, 19:44, Nicolas Frayer wrote:
> >> When the k3 socinfo driver is built as a module, there is a possibility
> >> that it will probe after the k3 udma driver and the later returns -ENODEV.
> >> By deferring the k3 udma probe we allow the k3 socinfo to probe and
> >> register the soc_device_attribute structure needed by the k3 udma driver.
> >> Removed the dev_err() message as well as it's deferring and not failing.
> >
> > lgtm, but need rebase as I already picked commit 3f58e10615f3 dmaengine: ti:
> > k3-udma: Add support for BCDMA CSI RX
>
> Is this path needed at all? afaik the k3 socinfo is not going to be
> module built.
>
> >
> >>
> >> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
> >> ---
> >> v1->v2:
> >> Extracted this patch from the following series:
> >> https://lore.kernel.org/all/20221108181144.433087-1-nfrayer@baylibre.com/
> >>
> >> v2->v3:
> >> Removed the dev_err() message
> >>
> >> drivers/dma/ti/k3-udma.c | 8 ++++----
> >> 1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> >> index ce8b80bb34d7..ca1512eb9910 100644
> >> --- a/drivers/dma/ti/k3-udma.c
> >> +++ b/drivers/dma/ti/k3-udma.c
> >> @@ -5271,10 +5271,10 @@ static int udma_probe(struct platform_device *pdev)
> >> ud->match_data = match->data;
> >>
> >> soc = soc_device_match(k3_soc_devices);
> >> - if (!soc) {
> >> - dev_err(dev, "No compatible SoC found\n");
> >> - return -ENODEV;
> >> - }
> >> +
> >> + if (!soc)
> >> + return -EPROBE_DEFER;
> >> +
> >> ud->soc_data = soc->data;
> >>
> >> ret = udma_get_mmrs(pdev, ud);
> >> --
> >> 2.25.1
> >
>
> --
> Péter
Hi Vinod, Péter,
This patch needs to be dropped as the k3 socinfo patch has been dropped.
Thanks,
Nicolas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-29 23:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-17 18:44 [PATCH v3] dmaengine: ti: k3-udma: Deferring probe when soc_device_match() returns NULL Nicolas Frayer
2022-11-18 20:11 ` Kevin Hilman
2022-12-28 11:16 ` Vinod Koul
2022-12-29 16:29 ` Péter Ujfalusi
2022-12-29 23:31 ` Nicolas Frayer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox