* [PATCH] arm64: dts: meson-axg-s400: Add chosen and memory nodes
@ 2018-09-10 18:33 Neil Armstrong
2018-09-10 18:45 ` Martin Blumenstingl
2018-09-13 4:58 ` Kevin Hilman
0 siblings, 2 replies; 4+ messages in thread
From: Neil Armstrong @ 2018-09-10 18:33 UTC (permalink / raw)
To: khilman; +Cc: Neil Armstrong, linux-amlogic, linux-arm-kernel, linux-kernel
Add missing chosen and memory nodes.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
index d399078..f0de884 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
@@ -60,6 +60,15 @@
serial1 = &uart_A;
};
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x0 0x0 0x40000000>;
+ };
+
main_12v: regulator-main_12v {
compatible = "regulator-fixed";
regulator-name = "12V";
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: meson-axg-s400: Add chosen and memory nodes
2018-09-10 18:33 [PATCH] arm64: dts: meson-axg-s400: Add chosen and memory nodes Neil Armstrong
@ 2018-09-10 18:45 ` Martin Blumenstingl
2018-09-11 13:28 ` Neil Armstrong
2018-09-13 4:58 ` Kevin Hilman
1 sibling, 1 reply; 4+ messages in thread
From: Martin Blumenstingl @ 2018-09-10 18:45 UTC (permalink / raw)
To: Neil Armstrong; +Cc: khilman, linux-amlogic, linux-kernel, linux-arm-kernel
On Mon, Sep 10, 2018 at 8:33 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Add missing chosen and memory nodes.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
out of curiosity:
- does the bootloader add the memory node (meaning that this is just a
cosmetic bit)?
- setting stdout-path is always a good idea, without it you can't use
earlycon (without parameters)
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: meson-axg-s400: Add chosen and memory nodes
2018-09-10 18:45 ` Martin Blumenstingl
@ 2018-09-11 13:28 ` Neil Armstrong
0 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2018-09-11 13:28 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: khilman, linux-amlogic, linux-kernel, linux-arm-kernel
Hi Martin,
On 10/09/2018 20:45, Martin Blumenstingl wrote:
> On Mon, Sep 10, 2018 at 8:33 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Add missing chosen and memory nodes.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> out of curiosity:
> - does the bootloader add the memory node (meaning that this is just a
> cosmetic bit)?
Yes, but it's always better to already have the node so it only change the memory,
otherwise it has to relocate and insert a node in the middle of the dtb.
> - setting stdout-path is always a good idea, without it you can't use
> earlycon (without parameters)
>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
Thanks,
Neil
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: meson-axg-s400: Add chosen and memory nodes
2018-09-10 18:33 [PATCH] arm64: dts: meson-axg-s400: Add chosen and memory nodes Neil Armstrong
2018-09-10 18:45 ` Martin Blumenstingl
@ 2018-09-13 4:58 ` Kevin Hilman
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2018-09-13 4:58 UTC (permalink / raw)
To: Neil Armstrong; +Cc: linux-amlogic, linux-arm-kernel, linux-kernel
Neil Armstrong <narmstrong@baylibre.com> writes:
> Add missing chosen and memory nodes.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Applied to v4.20/dt64 with Martin's ack.
Thanks,
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-13 4:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-10 18:33 [PATCH] arm64: dts: meson-axg-s400: Add chosen and memory nodes Neil Armstrong
2018-09-10 18:45 ` Martin Blumenstingl
2018-09-11 13:28 ` Neil Armstrong
2018-09-13 4:58 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox