public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PM / domains: Align column headers and data in pm_genpd_summary output
@ 2015-08-11 12:50 Geert Uytterhoeven
  2015-08-11 15:29 ` Kevin Hilman
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-08-11 12:50 UTC (permalink / raw)
  To: Rafael J. Wysocki, Kevin Hilman, Ulf Hansson, Maciej Matraszek
  Cc: linux-pm, linux-kernel, Geert Uytterhoeven

"domain": header is indented by 4, data by 0 spaces => 0 spaces
"/device": header is indented by 11, data by 4 spaces => 4 spaces
"slaves": header is indented by 47, data by 49 spaces => 48 spaces

Ruler:
    1234567890123456789012345678901234567890123456789012345678901234567890

Before:

	domain                      status         slaves
	       /device                                      runtime status
    ----------------------------------------------------------------------
    a3sp                            on               a2us
	/devices/platform/e60b0000.i2c                      suspended

After:

    domain                          status          slaves
	/device                                             runtime status
    ----------------------------------------------------------------------
    a3sp                            on              a2us
	/devices/platform/e60b0000.i2c                      suspended

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/base/power/domain.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index c9bc913a938c31e0..a0a99d55022f5387 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -2082,7 +2082,7 @@ static int pm_genpd_summary_one(struct seq_file *s,
 
 	if (WARN_ON(genpd->status >= ARRAY_SIZE(status_lookup)))
 		goto exit;
-	seq_printf(s, "%-30s  %-15s  ", genpd->name, status_lookup[genpd->status]);
+	seq_printf(s, "%-30s  %-15s ", genpd->name, status_lookup[genpd->status]);
 
 	/*
 	 * Modifications on the list require holding locks on both
@@ -2117,8 +2117,8 @@ static int pm_genpd_summary_show(struct seq_file *s, void *data)
 	struct generic_pm_domain *genpd;
 	int ret = 0;
 
-	seq_puts(s, "    domain                      status         slaves\n");
-	seq_puts(s, "           /device                                      runtime status\n");
+	seq_puts(s, "domain                          status          slaves\n");
+	seq_puts(s, "    /device                                             runtime status\n");
 	seq_puts(s, "----------------------------------------------------------------------\n");
 
 	ret = mutex_lock_interruptible(&gpd_list_lock);
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] PM / domains: Align column headers and data in pm_genpd_summary output
  2015-08-11 12:50 [PATCH] PM / domains: Align column headers and data in pm_genpd_summary output Geert Uytterhoeven
@ 2015-08-11 15:29 ` Kevin Hilman
  0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2015-08-11 15:29 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rafael J. Wysocki, Ulf Hansson, Maciej Matraszek, linux-pm,
	linux-kernel

Geert Uytterhoeven <geert+renesas@glider.be> writes:

> "domain": header is indented by 4, data by 0 spaces => 0 spaces
> "/device": header is indented by 11, data by 4 spaces => 4 spaces
> "slaves": header is indented by 47, data by 49 spaces => 48 spaces
>
> Ruler:
>     1234567890123456789012345678901234567890123456789012345678901234567890
>
> Before:
>
> 	domain                      status         slaves
> 	       /device                                      runtime status
>     ----------------------------------------------------------------------
>     a3sp                            on               a2us
> 	/devices/platform/e60b0000.i2c                      suspended
>
> After:
>
>     domain                          status          slaves
> 	/device                                             runtime status
>     ----------------------------------------------------------------------
>     a3sp                            on              a2us
> 	/devices/platform/e60b0000.i2c                      suspended
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Kevin Hilman <khilman@linaro.org>

> ---
>  drivers/base/power/domain.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index c9bc913a938c31e0..a0a99d55022f5387 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -2082,7 +2082,7 @@ static int pm_genpd_summary_one(struct seq_file *s,
>  
>  	if (WARN_ON(genpd->status >= ARRAY_SIZE(status_lookup)))
>  		goto exit;
> -	seq_printf(s, "%-30s  %-15s  ", genpd->name, status_lookup[genpd->status]);
> +	seq_printf(s, "%-30s  %-15s ", genpd->name, status_lookup[genpd->status]);
>  
>  	/*
>  	 * Modifications on the list require holding locks on both
> @@ -2117,8 +2117,8 @@ static int pm_genpd_summary_show(struct seq_file *s, void *data)
>  	struct generic_pm_domain *genpd;
>  	int ret = 0;
>  
> -	seq_puts(s, "    domain                      status         slaves\n");
> -	seq_puts(s, "           /device                                      runtime status\n");
> +	seq_puts(s, "domain                          status          slaves\n");
> +	seq_puts(s, "    /device                                             runtime status\n");
>  	seq_puts(s, "----------------------------------------------------------------------\n");
>  
>  	ret = mutex_lock_interruptible(&gpd_list_lock);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-11 15:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-11 12:50 [PATCH] PM / domains: Align column headers and data in pm_genpd_summary output Geert Uytterhoeven
2015-08-11 15:29 ` Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox