Re: [PATCH V2 11/15] cpufreq: mediatek: Update logic of voltage_tracking()

Kevin Hilman
2022-04-08T21:08:44Z

Rex-BC Chen <rex-bc.chen@mediatek.com> writes:

> From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
>
> - Remove VOLT_TOL because CCI may share the same sram and vproc
> regulators with CPU. Therefore, set the max voltage in
> regulator_set_voltage() to the proc{sram}_max_volt.

This could you a bit more detailed explanation. Why does VOLT_TOL get
in the way when regulators are shared between CPU & CCI?

> - Move comparison of new and old voltages to
> mtk_cpufreq_voltage_tracking().

Why? And how is this related to the above change? Seems to me that it
belongs in a separate patch.

Kevin