Re: [PATCH V2 15/15] cpufreq: mediatek: Use device print to show logs

Rex-BC Chen
2022-04-11T11:11:47Z

On Mon, 2022-04-11 at 08:59 +0530, Viresh Kumar wrote:
> On 08-04-22, 12:59, Rex-BC Chen wrote:
> > Replace pr_* with dev_* to show logs.
> >
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > ---
> > drivers/cpufreq/mediatek-cpufreq.c | 41 +++++++++++++++++---------
> > ----
> > 1 file changed, 23 insertions(+), 18 deletions(-)
>
> One should always arrange the patches in this form:
>
> - Fix bugs first (since they need to be applied first and need to go
> to stable kernels too).
>
> - Trivial fixes next, like this one which you chose to be present at
> 15/15. I would have applied this one right away, if it wasn't he
> last one, because of which we have conflicts now.
>
> - Non-trivial patches later, so reviews on them don't affect other
> patches.
>
Hello Viresh,

Thanks for your review and suggestions.
I will put this patch to first in next version.

BRs,
Rex