From: Kevin Hilman <khilman@baylibre.com>
To: Nishanth Menon <nm@ti.com>, Nicolas Frayer <nfrayer@baylibre.com>
Cc: ssantosh@kernel.org, linux-kernel@vger.kernel.org, glaroque@baylibre.com
Subject: Re: [PATCH v3] soc: ti: Convert allocations to devm
Date: Mon, 31 Oct 2022 09:34:22 -0700 [thread overview]
Message-ID: <7h8rkw2bqp.fsf@baylibre.com> (raw)
In-Reply-To: <20221028185647.d74ncedmocfbr2s4@debating>
Nishanth Menon <nm@ti.com> writes:
> On 20:00-20221028, Nicolas Frayer wrote:
>
> Quick cosmetics:
> linux-arm-kernel@lists.infradead.org (moderated list:TI KEYSTONE MULTICORE NAVIGATOR DRIVERS)
> is part of the results of get_maintainers.pl why drop not CC it?
>
> git log --oneline drivers/soc/ti/k3-socinfo.c
> soc: ti: k3-socinfo:
>
> Please fix the $subject
>
>> Changed the memory and resource allocations in the probe function
>> to devm. Also added a remove callback.
>
> Yes, but why are we doing this change, what benefit do we get by doing
> this change?
>
>
>>
>> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
>> ---
>>
>> v2->v3:
>> dropped module conversion part of this series while other driver dependencies
>> on socinfo are worked out.
>> A dependency issue is introduced by changing subsys_initcall()
>> to module_platform_driver(). Some drivers using the socinfo information probe
>> before the socinfo driver itself and it makes their probe fail.
>>
>> Dropped series:
>> https://lore.kernel.org/all/20221010131538.7333-1-nfrayer@baylibre.com/
>
> OK - if we are'nt going to convert this into modules, then is there a
> reason for this patch?
Yeah, Nishanth has a good point here. Lets wait on this patch an
included it with the module conversion once we figure out the deferred
probe issues around this.
Kevin
prev parent reply other threads:[~2022-10-31 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 18:00 [PATCH v3] soc: ti: Convert allocations to devm Nicolas Frayer
2022-10-28 18:56 ` Nishanth Menon
2022-10-31 16:34 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h8rkw2bqp.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=glaroque@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nfrayer@baylibre.com \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox