From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55E19C433FE for ; Thu, 14 Apr 2022 21:55:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242599AbiDNV6S (ORCPT ); Thu, 14 Apr 2022 17:58:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229878AbiDNV6Q (ORCPT ); Thu, 14 Apr 2022 17:58:16 -0400 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4E958C7DC for ; Thu, 14 Apr 2022 14:55:50 -0700 (PDT) Received: by mail-pl1-f172.google.com with SMTP id v12so5805678plv.4 for ; Thu, 14 Apr 2022 14:55:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=p4J2D9Y15bbl4a0Y5YpwKfGg6ieiA8wDXYDXSztcbAg=; b=gYsFAM0898ddQVRNitWqokN+izJi3j4/S+FQwTfGpsRZdddJ3vsUb9vXofMm7xlaw9 DIGZK38e932I2p9fOcIX9zxrAxunG9KV6C4zw4A5SASpY1kZa8xHYbh6hFkGfGghk8oa aMNsMDpYhVKxgvmbu9fnQ4CXwbyuFFzFHlwnTF0cyYdMb7RUOMtDG8DfDX3nWlzeOmSO CA6r6zGBtzydQXzweba//kb7IzPot4/iav6fback1x0TFzyeM3KWIPP3fiDLKQMsH7+s MlRkXSPzOIb9xX1Vt9Kx6gxg/FCqfV7afIaDbqOEdorT/3byrGdoplnnF8cCVoVUjlqH X8vw== X-Gm-Message-State: AOAM530odbon2mYDYM1MQTEVBx8RBdp6PQ0KW7cO/oqsJXXP/ivewFc5 ylMpXxin2CyVodcxC9dK4rB7Vw== X-Google-Smtp-Source: ABdhPJyib/M2xHCFWUypNYp+D6C2ZjbS7N2LMqLSJuQA+fqFc93KdJyuod9xrHqWJH5vlAixigjz8w== X-Received: by 2002:a17:902:b7c4:b0:158:c493:e0fd with SMTP id v4-20020a170902b7c400b00158c493e0fdmr2748522plz.20.1649973350236; Thu, 14 Apr 2022 14:55:50 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id s24-20020a17090a441800b001ca9b5724a6sm2711383pjg.36.2022.04.14.14.55.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 14:55:49 -0700 (PDT) From: Kevin Hilman To: Krzysztof Kozlowski , Johnson Wang , cw00.choi@samsung.com, krzk+dt@kernel.org, robh+dt@kernel.org, kyungmin.park@samsung.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, jia-wei.chang@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v2 1/2] dt-bindings: devfreq: mediatek: Add mtk cci devfreq dt-bindings In-Reply-To: <39152c86-ca11-2792-6b25-ae55ffb47b09@linaro.org> References: <20220408052150.22536-1-johnson.wang@mediatek.com> <20220408052150.22536-2-johnson.wang@mediatek.com> <855d7daa-45d1-d6d8-32bd-51778cf58392@linaro.org> <39152c86-ca11-2792-6b25-ae55ffb47b09@linaro.org> Date: Thu, 14 Apr 2022 14:55:49 -0700 Message-ID: <7h8rs7fhy2.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Krzysztof Kozlowski writes: > On 11/04/2022 14:10, Johnson Wang wrote: >>> Also please put it in the "interconnect" directory. >>> >> >> I don't really know about "interconnect". >> However, it looks like a Linux framework about data transfer and "NoC". >> >> While this cci driver is more like a power managment which is >> responsible for adjusting voltages and frequencies. >> In my opinion, "devfreq" should be more suitable. >> >> Please correct me if my understanding is wrong. > > devfreq is a Linux mechanism, not a real device/hardware. We try to put > the bindings in directories/subsystems matching the hardware, therefore > devfreq is not appropriate. > > Whether interconnect - or other subsystem - is appropriate, I am not > sure. To me this looks exactly like bus bandwidth management and you > even use "interconnect" in several places. So interconnect matches. I agree with Krzysztof that "interconnect" is the right place. I'm pretty sure CCI stands for "cache coherent interconnect". At least that's what it means for the Arm IP. The Mediatek IP being described here certainly seems like the same thing. It's just that the only aspects being described (so far) are the DVFS parts. Even so, I still think it belongs in "interconnect" Kevin