From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbdJSKZf (ORCPT ); Thu, 19 Oct 2017 06:25:35 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:56046 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbdJSKZd (ORCPT ); Thu, 19 Oct 2017 06:25:33 -0400 X-Google-Smtp-Source: ABhQp+QPl+8S90CZuOTVuIw0sYZA5gvrT3Prrq6gvxQwVv1by8xW8lm2xU/2B5271vsZ0YlOuabqDQ== From: Kevin Hilman To: Rob Herring Cc: Jerome Brunet , Carlo Caione , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: meson-sm: use generic compatible Organization: BayLibre References: <20171012134743.10625-1-jbrunet@baylibre.com> <20171017204959.kfbhn2yxhv2sb5qg@rob-hp-laptop> Date: Thu, 19 Oct 2017 12:25:30 +0200 In-Reply-To: <20171017204959.kfbhn2yxhv2sb5qg@rob-hp-laptop> (Rob Herring's message of "Tue, 17 Oct 2017 15:50:00 -0500") Message-ID: <7h8tg7zb6t.fsf@baylibre.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rob Herring writes: > On Thu, Oct 12, 2017 at 03:47:43PM +0200, Jerome Brunet wrote: >> The meson secure monitor seems to be compatible with more SoCs than >> initially thought. Let's use the most generic compatible he have in >> DT instead of the gxbb specific one >> >> Signed-off-by: Jerome Brunet >> --- >> Documentation/devicetree/bindings/firmware/meson/meson_sm.txt | 4 ++-- >> drivers/firmware/meson/meson_sm.c | 4 ++-- >> 2 files changed, 4 insertions(+), 4 deletions(-) > > Seems like a pointless, not backwards compatible change to me. I've verified that it's backwards compatible with existing upstream DTs. > end, it's just a string to match on. Who cares what the string is. As platform maintiner, I very much care what the strings are and I want it to be coherent with the platform generic names, and I want the SoC-specific strings to correspond to the actual SoC names. Kevin