From: Kevin Hilman <khilman@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@kernel.org>, "Tejun Heo" <tj@kernel.org>,
"Li Zefan" <lizefan@huawei.com>,
"Lists linaro-kernel" <linaro-kernel@lists.linaro.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>
Subject: Re: [RFC 2/4] timer: don't migrate pinned timers
Date: Fri, 04 Apr 2014 08:15:19 -0700 [thread overview]
Message-ID: <7h8urlyvlk.fsf@paris.lan> (raw)
In-Reply-To: <CAKohpokYfdY+40kmhgrC6Yr9vfv4GtAW2Ph3+=57YbfmJsnU9w@mail.gmail.com> (Viresh Kumar's message of "Tue, 1 Apr 2014 10:02:43 +0530")
Viresh Kumar <viresh.kumar@linaro.org> writes:
> On 31 March 2014 21:26, Kevin Hilman <khilman@linaro.org> wrote:
>> Viresh Kumar <viresh.kumar@linaro.org> writes:
>>> + if (is_pinned) {
>>> + pr_warn("%s: can't migrate pinned timer: %p, removing it\n",
>>> + __func__, timer);
>>
>> printk message will be confusing: removing it from what?
>
> Hmm.. So, I am looking to do two modifications here. Just need inputs
> if that would be the right thing to do:
>
> - do a WARN() here as these timers should have been already removed
> - change print to: "can't migrate pinned timer %p, deactivating timer"
>
> Looks fine?
Yes.
next prev parent reply other threads:[~2014-04-04 15:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 13:48 [RFC 0/4] Migrate timers away from cpuset on setting cpuset.quiesce Viresh Kumar
2014-03-20 13:48 ` [RFC 1/4] timer: track pinned timers with TIMER_PINNED flag Viresh Kumar
2014-03-20 13:48 ` [RFC 2/4] timer: don't migrate pinned timers Viresh Kumar
2014-03-31 15:56 ` Kevin Hilman
2014-04-01 4:32 ` Viresh Kumar
2014-04-04 15:15 ` Kevin Hilman [this message]
2014-03-20 13:49 ` [RFC 3/4] timer: create timer_quiesce_cpu() for cpusets.quiesce option Viresh Kumar
2014-03-20 13:49 ` [RFC 4/4] cpuset: Add " Viresh Kumar
2014-03-27 2:47 ` Li Zefan
2014-03-27 4:29 ` Viresh Kumar
2014-04-24 7:25 ` [RFC 0/4] Migrate timers away from cpuset on setting cpuset.quiesce Daniel Sangorrin
2014-04-24 7:43 ` Viresh Kumar
2014-04-24 8:31 ` Daniel Sangorrin
2014-04-24 8:41 ` Viresh Kumar
2014-04-24 9:24 ` Daniel Sangorrin
2014-04-24 9:30 ` Viresh Kumar
2014-04-25 0:31 ` Daniel Sangorrin
2014-04-25 4:51 ` Viresh Kumar
2014-04-25 5:21 ` Daniel Sangorrin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h8urlyvlk.fsf@paris.lan \
--to=khilman@linaro.org \
--cc=cgroups@vger.kernel.org \
--cc=fweisbec@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox