From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752231AbcEYUvE (ORCPT ); Wed, 25 May 2016 16:51:04 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33336 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbcEYUvA (ORCPT ); Wed, 25 May 2016 16:51:00 -0400 From: Kevin Hilman To: Andy Gross Cc: linux-arm-msm , linux-arm-kernel , lkml , Bjorn Andersson , Stephen Boyd , devicetree , jilai wang Subject: Re: [Patch v5 5/8] firmware: qcom: scm: Convert to streaming DMA APIS Organization: BayLibre References: <1463111221-6963-1-git-send-email-andy.gross@linaro.org> <1463111221-6963-6-git-send-email-andy.gross@linaro.org> <20160525033731.GA30220@hector.attlocal.net> Date: Wed, 25 May 2016 13:50:58 -0700 In-Reply-To: <20160525033731.GA30220@hector.attlocal.net> (Andy Gross's message of "Tue, 24 May 2016 22:37:31 -0500") Message-ID: <7hbn3tg8ul.fsf@baylibre.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Gross writes: > On Mon, May 23, 2016 at 04:02:06PM -0500, Andy Gross wrote: >> On 23 May 2016 at 14:26, Kevin Hilman wrote: >> > Hi Andy, >> > >> > On Thu, May 12, 2016 at 8:46 PM, Andy Gross wrote: >> >> This patch converts the Qualcomm SCM driver to use the streaming DMA APIs >> >> for communication buffers. >> >> >> >> Signed-off-by: Andy Gross >> > >> > This patch has landed in linux-next in the form of commit a551c3dbd689 >> > (firmware: qcom: scm: Convert to streaming DMA APIS), and kernelci.org >> > found some boot breakage in next-20160523 on apq8064[1] which was >> > bisected down to this commit. >> > >> > I reverted this commit on top of next-20160523 and it no longer >> > builds, so I didn't validate if things boot again with this patch >> > reverted. >> >> Ouch I missed this failure. I'll investigate and get it fixed. > > So the root cause was the fact that the DFAB clock required by the SCM is an RPM > clock. That support isn't present yet in the kernel, so SCM probe fails. > > The core clock is really only accessed so that we can bump the clock on it up to > the max for performance. As such, I'll make it optional in the platform code. > > This does bring up the issue of probe defer causing issues with the spm driver, > as it calls set_warm_boot_addr. That may have to be addressed, but is probably > a problem best fixed in the spm. Nice, thanks for the explanation. Is there a patch somewhere you'd like me to test? or were you able to dust off an 8064 platform for testing? Kevin