From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B88C433FE for ; Fri, 8 Apr 2022 21:08:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239654AbiDHVKr (ORCPT ); Fri, 8 Apr 2022 17:10:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238798AbiDHVKo (ORCPT ); Fri, 8 Apr 2022 17:10:44 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A03B814D795 for ; Fri, 8 Apr 2022 14:08:37 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id q142so8752683pgq.9 for ; Fri, 08 Apr 2022 14:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=HoLWT/EythxVH1YT+vEjLN2TXDPwfF5xPPqMajsg97o=; b=6DqRW4gK+PKLqJfJdAd0TGTO95Ya7KDB3mBZJjKMlL0nxZLtgxfpl+75BDL9PpUtD/ D8sxCCmecY9A1jNHsGn59jfaYAYVcw0MXiJZsMdhW9Hgaj2eegEWYZqhsHZZ8RViFFh8 g/mUJ5pRz/mDzFZbqiAMFiy2sA1QwSdm7uJ+N0EWGsnS9ZjEVfmjTnqFmuhMnW10Edv7 uODRBJwh1af7cUiTZDMOJnhCYENwjfab4lz7/KYYJOcswfmpJxqrQ5/bp0tB9mIV7ZMt Kceie9MXCbkN4vkioRj3xK49n2u3J7v+iyzNlDM+Hsx6W8Dz7u6YcGhollnP1Te9u94x iUtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=HoLWT/EythxVH1YT+vEjLN2TXDPwfF5xPPqMajsg97o=; b=mv/36JgYyMM+tISbjkleyB55KpQZYLlk6S4s0t2FVmM5oAtQsKUcilZdEa0B16s4xq tA7Lm9vKRhfA07JxfmlaLLqwdfv5P5wl5f2MTle+kxCZm1LONovkrgtnBUGH0fpHDyBw ZHn3IDzShENrq8tAt+L2C1htEgU+p7+ZdtkOQcKnHDXhgTx6gfVJFj0aaQkXqDYwsiE0 cxtig6llf7RMmbpDzV8miNa4T9jlqOjBXQyKb/Qz5EpedtsZz6Ufu6mq4G/+rbMkwgZm veHdYqp6TMD8SnfQa5yazPQsKfDCLGTP+kiy55WUW9RQGwiZ4hkDKLqRCzd82zUobwiF hd6w== X-Gm-Message-State: AOAM531jfYHhmOpiKFIKtxdfS62JUS2JYT3D/WdEqD7CjE1npVw2o0L6 VL9bnCuQqOrBTi6Gz8Z3CpTtFQ== X-Google-Smtp-Source: ABdhPJyvhkTmr6m8xOSTjNCBilnTlNxx+TZTy+ro007JGG5u+GpijdOFdlxjLZjwIoz7WZTYTZhnOg== X-Received: by 2002:a63:c015:0:b0:385:fe06:eb86 with SMTP id h21-20020a63c015000000b00385fe06eb86mr16908387pgg.132.1649452117075; Fri, 08 Apr 2022 14:08:37 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id s10-20020a63924a000000b00399571b2f99sm12120792pgn.57.2022.04.08.14.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 14:08:36 -0700 (PDT) From: Kevin Hilman To: Rex-BC Chen , rafael@kernel.org, viresh.kumar@linaro.org, robh+dt@kernel.org, krzk+dt@kernel.org Cc: matthias.bgg@gmail.com, jia-wei.chang@mediatek.com, roger.lu@mediatek.com, hsinyi@google.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH V2 11/15] cpufreq: mediatek: Update logic of voltage_tracking() In-Reply-To: <20220408045908.21671-12-rex-bc.chen@mediatek.com> References: <20220408045908.21671-1-rex-bc.chen@mediatek.com> <20220408045908.21671-12-rex-bc.chen@mediatek.com> Date: Fri, 08 Apr 2022 14:08:36 -0700 Message-ID: <7hczhr5lm3.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rex-BC Chen writes: > From: Jia-Wei Chang > > - Remove VOLT_TOL because CCI may share the same sram and vproc > regulators with CPU. Therefore, set the max voltage in > regulator_set_voltage() to the proc{sram}_max_volt. This could you a bit more detailed explanation. Why does VOLT_TOL get in the way when regulators are shared between CPU & CCI? > - Move comparison of new and old voltages to > mtk_cpufreq_voltage_tracking(). Why? And how is this related to the above change? Seems to me that it belongs in a separate patch. Kevin