From: Kevin Hilman <khilman@kernel.org>
To: Nishanth Menon <nm@ti.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bb@ti.com, d-gole@ti.com, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH] cpufreq: ti-cpufreq: Introduce quirks to handle syscon fails appropriately
Date: Fri, 30 Aug 2024 10:59:24 -0700 [thread overview]
Message-ID: <7hjzfxx56r.fsf@baylibre.com> (raw)
In-Reply-To: <20240828131915.3198081-1-nm@ti.com>
Nishanth Menon <nm@ti.com> writes:
> Commit b4bc9f9e27ed ("cpufreq: ti-cpufreq: add support for omap34xx
> and omap36xx") introduced special handling for OMAP3 class devices
> where syscon node may not be present. However, this also creates a bug
> where the syscon node is present, however the offset used to read
> is beyond the syscon defined range.
>
> Fix this by providing a quirk option that is populated when such
> special handling is required. This allows proper failure for all other
> platforms when the syscon node and efuse offsets are mismatched.
>
> Fixes: b4bc9f9e27ed ("cpufreq: ti-cpufreq: add support for omap34xx and omap36xx")
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> NOTE: this combined with https://lore.kernel.org/r/20240828121008.3066002-1-nm@ti.com
> has created a bunch of un-intended bugs on other TI SoCs such
> as seen in https://lore.kernel.org/all/20240826-opp-v3-1-0934f8309e13@ti.com/
> https://lore.kernel.org/all/20240827131342.6wrielete3yeoinl@bryanbrattlof.com/
> etc.
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
next prev parent reply other threads:[~2024-08-30 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 13:19 [PATCH] cpufreq: ti-cpufreq: Introduce quirks to handle syscon fails appropriately Nishanth Menon
2024-08-30 10:04 ` Dhruva Gole
2024-08-30 17:59 ` Kevin Hilman [this message]
2024-09-03 9:02 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hjzfxx56r.fsf@baylibre.com \
--to=khilman@kernel.org \
--cc=bb@ti.com \
--cc=d-gole@ti.com \
--cc=hns@goldelico.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=tony@atomide.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox